Fix CheckFalseTest.CheckFails on Linux after my change to ui_test.

chrome/browser/profile_impl.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profile_impl.h"
 
 #include "app/resource_bundle.h"
 #include "base/command_line.h"
 #include "base/environment.h"
 #include "base/file_path.h"
@@ skipping 292 matching lines @@
         PathService::Get(base::DIR_USER_CACHE, &user_cache_path) &&
         app_data_path.AppendRelativePath(path_, &user_cache_path)) {
       base_cache_path_ = user_cache_path;
     }
   }
 #elif defined(OS_POSIX)  // Posix minus Mac.
   // See http://standards.freedesktop.org/basedir-spec/basedir-spec-latest.html
   // for a spec on where cache files go.  The net effect for most systems is we
   // use ~/.cache/chromium/ for Chromium and ~/.cache/google-chrome/ for
   // official builds.
-  if (!PathService::IsOverridden(chrome::DIR_USER_DATA)) {

[evanm, 2010/11/12 20:54:58]

FYI, this regressed having separate cache directories for different profiles on
Linux.

That is, even if you pass --user-data-dir=foo, this uses ~/.cache/google-chrome
for all running profiles.  They stomp on each other's caches and cause various
page corruption.

 #if defined(GOOGLE_CHROME_BUILD)
-    const char kCacheDir[] = "google-chrome";
+  const char kCacheDir[] = "google-chrome";
 #else
-    const char kCacheDir[] = "chromium";
+  const char kCacheDir[] = "chromium";
 #endif
-    PathService::Get(base::DIR_USER_CACHE, &base_cache_path_);
-    base_cache_path_ = base_cache_path_.Append(kCacheDir);
-    if (!file_util::PathExists(base_cache_path_))
-      file_util::CreateDirectory(base_cache_path_);
-  }
+  PathService::Get(base::DIR_USER_CACHE, &base_cache_path_);
+  base_cache_path_ = base_cache_path_.Append(kCacheDir);
+  if (!file_util::PathExists(base_cache_path_))
+    file_util::CreateDirectory(base_cache_path_);
 #endif
   if (base_cache_path_.empty())
     base_cache_path_ = path_;
 
   // Listen for theme installation.
   registrar_.Add(this, NotificationType::THEME_INSTALLED,
                  NotificationService::AllSources());
 
   // Listen for bookmark model load, to bootstrap the sync service.
   registrar_.Add(this, NotificationType::BOOKMARK_MODEL_LOADED,
@@ skipping 948 matching lines @@
 #if defined(OS_CHROMEOS)
 chromeos::ProxyConfigServiceImpl*
     ProfileImpl::GetChromeOSProxyConfigServiceImpl() {
   if (!chromeos_proxy_config_service_impl_) {
     chromeos_proxy_config_service_impl_ =
         new chromeos::ProxyConfigServiceImpl();
   }
   return chromeos_proxy_config_service_impl_;
 }
 #endif  // defined(OS_CHROMEOS)