Pulse new bookmarks (as triggered by bookmark bubble). If not possible, ...

Pulse new bookmarks (as triggered by bookmark bubble).  If not possible, 
pulse the topmost parent that is visible (e.g. "Other Bookmarks").

BUG=http://crbug.com/42028

TEST=\
Repeat this test with the following themes:
1) None, 2) Maria Carey, 3) Ocean Pacific, 4) American Apparel:
.
New profile.  Click star to 'mark something.  See bookmark pulse in bar.  Cancel.
Do that again, but set parent to "Other Bookmarks" and hit OK.
New page; click star.  Default parent is Other Bookmarks; see Other Bookmarks folder pulse.
Add enough bookmarks on bar so something falls in overflow menu (chevron appears).
Go to one of them, then click star.  (You can't see chevron pulse.. it's hidden.)
Create a folder.  Add a bookmark to the folder.  Go that page.
Click on star; see folder pulse.



Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53912

[Bons, 2010-07-22 19:01:01]

lgtm with changes...

http://codereview.chromium.org/2805099/diff/1/2
File chrome/browser/cocoa/bookmark_bar_controller.mm (right):

http://codereview.chromium.org/2805099/diff/1/2#newcode259
chrome/browser/cocoa/bookmark_bar_controller.mm:259:
bookmark_button::kBookmarkPulseFlagKey];
indentation

http://codereview.chromium.org/2805099/diff/1/2#newcode261
chrome/browser/cocoa/bookmark_bar_controller.mm:261: if (number)
For clarity, I try to declare my variables closest to when they are used as
opposed to all at the top of a function. There's a lot of stuff going on in
between where the doPulse BOOL is declared and this. You can also put it into a
tertiary expression:

BOOL doPulse = number ? [number boolValue] : NO;

http://codereview.chromium.org/2805099/diff/1/2#newcode283
chrome/browser/cocoa/bookmark_bar_controller.mm:283: DCHECK(0) << "no bookmark
button found to pulse!";
NOTREACHED() seems more appropriate, no?

http://codereview.chromium.org/2805099/diff/1/3
File chrome/browser/cocoa/bookmark_bar_controller_unittest.mm (right):

http://codereview.chromium.org/2805099/diff/1/3#newcode1
chrome/browser/cocoa/bookmark_bar_controller_unittest.mm:1: // Copyright (c)
2009 The Chromium Authors. All rights reserved.
2010 since you've altered it since the current date written. Same with any other
file you've altered here.

http://codereview.chromium.org/2805099/diff/1/3#newcode2041
chrome/browser/cocoa/bookmark_bar_controller_unittest.mm:2041:
dictionaryWithObjectsAndKeys:value,
more weird indentation here and below.

http://codereview.chromium.org/2805099/diff/1/3#newcode2064
chrome/browser/cocoa/bookmark_bar_controller_unittest.mm:2064: 
remove extra newline

http://codereview.chromium.org/2805099/diff/1/4
File chrome/browser/cocoa/bookmark_bubble_controller.h (right):

http://codereview.chromium.org/2805099/diff/1/4#newcode1
chrome/browser/cocoa/bookmark_bubble_controller.h:1: // Copyright (c) 2009 The
Chromium Authors. All rights reserved.
2010

http://codereview.chromium.org/2805099/diff/1/4#newcode30
chrome/browser/cocoa/bookmark_bubble_controller.h:30: const BookmarkNode*
pulsingBookmarkNode_;  // weak like all bookmark nodes
if all bookmark nodes are weak then it seems to belong in the class description
or at least add the same comment to the BookmarkNode above. Or just delete that
nugget of info since you can pretty much tell from two lines above that bookmark
nodes are weak. canyoutelli'vehadcoffee?

http://codereview.chromium.org/2805099/diff/1/5
File chrome/browser/cocoa/bookmark_bubble_controller.mm (right):

http://codereview.chromium.org/2805099/diff/1/5#newcode123
chrome/browser/cocoa/bookmark_bubble_controller.mm:123:
bookmark_button::kBookmarkKey,
indentation.

http://codereview.chromium.org/2805099/diff/1/5#newcode142
chrome/browser/cocoa/bookmark_bubble_controller.mm:142:
bookmark_button::kBookmarkKey,
iiiiiindentation.

http://codereview.chromium.org/2805099/diff/1/6
File chrome/browser/cocoa/bookmark_bubble_controller_unittest.mm (right):

http://codereview.chromium.org/2805099/diff/1/6#newcode1
chrome/browser/cocoa/bookmark_bubble_controller_unittest.mm:1: // Copyright (c)
2009 The Chromium Authors. All rights reserved.
2010.

http://codereview.chromium.org/2805099/diff/1/7
File chrome/browser/cocoa/bookmark_button.h (right):

http://codereview.chromium.org/2805099/diff/1/7#newcode229
chrome/browser/cocoa/bookmark_button.h:229: 
extra newline.

http://codereview.chromium.org/2805099/diff/1/8
File chrome/browser/cocoa/bookmark_button.mm (right):

http://codereview.chromium.org/2805099/diff/1/8#newcode67
chrome/browser/cocoa/bookmark_button.mm:67: -
(void)setContinuousPulse:(BOOL)flag {
setIsContinuouslyPulsing?

http://codereview.chromium.org/2805099/diff/1/10
File chrome/browser/cocoa/gradient_button_cell.mm (right):

http://codereview.chromium.org/2805099/diff/1/10#newcode111
chrome/browser/cocoa/gradient_button_cell.mm:111: CHECK(0);
NOTREACHED again?

http://codereview.chromium.org/2805099/diff/1/10#newcode143
chrome/browser/cocoa/gradient_button_cell.mm:143: 1.0 : 0.0];
indentation. here and below with similar line.

[John Grabowski, 2010-07-26 21:31:47]

final diffs up; feedback applied.  thx.