Issue 2805097: Fixes the regex used to test for the Mac platform.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2805097: Fixes the regex used to test for the Mac platform. (Closed)

Created:
10 years, 5 months ago by kurrik.chromium

Modified:
9 years, 7 months ago

Reviewers:
arv (Not doing code reviews)

CC:
chromium-reviews, arv (Not doing code reviews), ben+cc_chromium.org

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

Fixes the regex used to test for the Mac platform. BUG=49809 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53237

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/resources/ntp/util.js	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

arv (Not doing code reviews)

10 years, 5 months ago (2010-07-21 19:45:39 UTC) #2

LGTM

erik



On Wed, Jul 21, 2010 at 11:44,  <kurrik@chromium.org> wrote:
> Reviewers: arv,
>
> Description:
> Fixes the regex used to test for the Mac platform.
>
> BUG=49809
> TEST=None
>
> Please review this at http://codereview.chromium.org/2805097/show
>
> SVN Base: http://src.chromium.org/git/chromium.git
>
> Affected files:
>  M chrome/browser/resources/ntp/util.js
>
>
> Index: chrome/browser/resources/ntp/util.js
> diff --git a/chrome/browser/resources/ntp/util.js
> b/chrome/browser/resources/ntp/util.js
> index
>
ab99ec253a7964357fd301d99c3ccc48062aa848..b75935649343d6712cd1523b31162e2088fd1d2f
> 100644
> --- a/chrome/browser/resources/ntp/util.js
> +++ b/chrome/browser/resources/ntp/util.js
> @@ -5,7 +5,7 @@
>  // TODO(arv): Move to shared/js once namespaced and tested.
>
>  var global = this;
> -const IS_MAC = /$Mac/.test(navigator.platform);
> +const IS_MAC = /^Mac/.test(navigator.platform);
>
>  function $(id) {
>   return document.getElementById(id);
>
>
>

Expand Messages | Collapse Messages