Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(654)

Unified Diff: chrome/browser/download/download_file_manager.h

Issue 2805091: Download code cleanup: (Closed)
Patch Set: rebased Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/tuple.h ('k') | chrome/browser/download/download_file_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/download/download_file_manager.h
diff --git a/chrome/browser/download/download_file_manager.h b/chrome/browser/download/download_file_manager.h
index f4c1a5e89ab3e3c50933afe1606c96c46f7ac690..bfccbfd788be3df9a41c891ca0be682be76eef77 100644
--- a/chrome/browser/download/download_file_manager.h
+++ b/chrome/browser/download/download_file_manager.h
@@ -78,16 +78,6 @@ class DownloadFileManager
void CancelDownload(int id);
void DownloadFinished(int id, DownloadBuffer* buffer);
- // Download the URL. Called on the UI thread and forwarded to the
- // ResourceDispatcherHost on the IO thread.
- void DownloadUrl(const GURL& url,
- const GURL& referrer,
- const std::string& referrer_charset,
- const DownloadSaveInfo& save_info,
- int render_process_host_id,
- int render_view_id,
- URLRequestContextGetter* request_context_getter);
-
// Called on the UI thread to remove a download item or manager.
void RemoveDownloadManager(DownloadManager* manager);
void RemoveDownload(int id, DownloadManager* manager);
@@ -123,15 +113,6 @@ class DownloadFileManager
// Clean up helper that runs on the download thread.
void OnShutdown();
- // Run on the IO thread to initiate the download of a URL.
- void OnDownloadUrl(const GURL& url,
- const GURL& referrer,
- const std::string& referrer_charset,
- const DownloadSaveInfo& save_info,
- int render_process_host_id,
- int render_view_id,
- URLRequestContextGetter* request_context_getter);
-
// Handlers for notifications sent from the download thread and run on
// the UI thread.
void OnStartDownload(DownloadCreateInfo* info);
@@ -140,10 +121,10 @@ class DownloadFileManager
// Called only on UI thread to get the DownloadManager for a tab's profile.
static DownloadManager* DownloadManagerFromRenderIds(int render_process_id,
int review_view_id);
- DownloadManager* LookupManager(int download_id);
+ DownloadManager* GetDownloadManager(int download_id);
// Called only on the download thread.
- DownloadFile* LookupDownload(int id);
+ DownloadFile* GetDownloadFile(int id);
// Called on the UI thread to remove a download from the UI progress table.
void RemoveDownloadFromUIProgress(int id);
« no previous file with comments | « base/tuple.h ('k') | chrome/browser/download/download_file_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698