Download code cleanup:

Download code cleanup:

- choose better names for some helper methods
- move code to less random places

This change also adds bigger tuples support, up to Tuple8 in base/tuple.h.
The plan is to stop using such big number of parameters, but for now it's not
trivial.

This change also fixes some UI tests, not sure why it is so.

TEST=unit_tests, browser_tests, ui_tests
BUG=48913
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53053

[darin (slow to review), 2010-07-20 06:06:14]

I don't understand the changes to the expected results.  Otherwise, LGTM.

[Bernhard Bauer, 2010-07-20 09:04:06]

On 2010/07/20 06:06:14, darin wrote:
> I don't understand the changes to the expected results.  Otherwise, LGTM.

LGTM as well.

[Paweł Hajdan Jr., 2010-07-20 16:42:37]

On 2010/07/20 06:06:14, darin wrote:
> I don't understand the changes to the expected results.

Yeah, I'm not surprised it's mysterious. :-/ It turns out it was caused by some
WebKit change, and already fixed in the tree
(http://codereview.chromium.org/3047003/show). We didn't notice it earlier
because the tests are marked as FLAKY.

[darin (slow to review), 2010-07-20 16:51:23]

OK

On Tue, Jul 20, 2010 at 9:42 AM, <phajdan.jr@chromium.org> wrote:

> On 2010/07/20 06:06:14, darin wrote:
>
>> I don't understand the changes to the expected results.
>>
>
> Yeah, I'm not surprised it's mysterious. :-/ It turns out it was caused by
> some
> WebKit change, and already fixed in the tree
> (http://codereview.chromium.org/3047003/show). We didn't notice it earlier
> because the tests are marked as FLAKY.
>
>
> http://codereview.chromium.org/2805091/show
>