Changing the pre-reading of chrome.dll to read it as an image section instead...

Changing the pre-reading of chrome.dll to read it as an image section instead. XP ignores pages read as data
while mapping image sections. This shows a reasonable improvement in cold startup performance on XP.

This change only comes into effect for headless mode which enables us to try out the effect on the perf bots
and for chrome frame processes.

Code mostly written by Amit.

Added a chrome frame perf tests which measures LoadLibrary in cold mode with pre-reading.

Bug=45510
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51594

[slightlyoff, 2010-07-02 20:56:14]

Nit in tests. LGTM.

http://codereview.chromium.org/2805064/diff/10001/11004
File chrome_frame/test/perf/chrome_frame_perftest.cc (right):

http://codereview.chromium.org/2805064/diff/10001/11004#newcode955
chrome_frame/test/perf/chrome_frame_perftest.cc:955: FilePath
binaries_to_evict[] = {chrome_exe_, chrome_dll_};
this should probably evict more of the DLLs, see line 939 above for the fuller
list.

[stoyan, 2010-07-02 23:30:00]

ok

[ananta, 2010-07-03 15:51:01]

http://codereview.chromium.org/2805064/diff/10001/11004
File chrome_frame/test/perf/chrome_frame_perftest.cc (right):

http://codereview.chromium.org/2805064/diff/10001/11004#newcode955
chrome_frame/test/perf/chrome_frame_perftest.cc:955: FilePath
binaries_to_evict[] = {chrome_exe_, chrome_dll_};
On 2010/07/02 20:56:15, slightlyoff wrote:
> this should probably evict more of the DLLs, see line 939 above for the fuller
> list.
chrome.dll's loadlibrary call for now has the maximum overhead. We can update
this list with other dlls when we need them.

[joshia, 2010-07-03 15:58:02]

On Sat, Jul 3, 2010 at 8:51 AM, <ananta@chromium.org> wrote:

>
> http://codereview.chromium.org/2805064/diff/10001/11004
> File chrome_frame/test/perf/chrome_frame_perftest.cc (right):
>
> http://codereview.chromium.org/2805064/diff/10001/11004#newcode955
> chrome_frame/test/perf/chrome_frame_perftest.cc:955: FilePath
> binaries_to_evict[] = {chrome_exe_, chrome_dll_};
> On 2010/07/02 20:56:15, slightlyoff wrote:
>
>> this should probably evict more of the DLLs, see line 939 above for
>>
> the fuller
>
>> list.
>>
> chrome.dll's loadlibrary call for now has the maximum overhead. We can
> update this list with other dlls when we need them.

I think Alex meant to evict the other DLLs that will get loaded with
LoadLibrary of chrome.dll in order to get consistent results. Will the
codecs, rlz etc get loaded with LoadLibrary or they are delay loaded?

>
>
> http://codereview.chromium.org/2805064/show
>

[slightlyoff, 2010-07-03 19:10:40]

On Sat, Jul 3, 2010 at 8:57 AM, Amit Joshi <joshia@google.com> wrote:
>
>
> On Sat, Jul 3, 2010 at 8:51 AM, <ananta@chromium.org> wrote:
>>
>> http://codereview.chromium.org/2805064/diff/10001/11004
>> File chrome_frame/test/perf/chrome_frame_perftest.cc (right):
>>
>> http://codereview.chromium.org/2805064/diff/10001/11004#newcode955
>> chrome_frame/test/perf/chrome_frame_perftest.cc:955: FilePath
>> binaries_to_evict[] = {chrome_exe_, chrome_dll_};
>> On 2010/07/02 20:56:15, slightlyoff wrote:
>>>
>>> this should probably evict more of the DLLs, see line 939 above for
>>
>> the fuller
>>>
>>> list.
>>
>> chrome.dll's loadlibrary call for now has the maximum overhead. We can
>> update this list with other dlls when we need them.
>
> I think Alex meant to evict the other DLLs that will get loaded with
> LoadLibrary of chrome.dll in order to get consistent results. Will the
> codecs, rlz etc get loaded with LoadLibrary or they are delay loaded?

There's no delay loading for renderers. Yes, they're just
LoadLibrary'd in, but their DllMains (etc.) will be called.