Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(693)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2805052: Relocate library files for wider access and re-use; also associated cleanup. (Closed)

Created:
10 years, 5 months ago by Tammo Spalink
Modified:
9 years, 7 months ago
CC:
chromium-os-reviews_chromium.org, sosa+cc_chromium.org, seano, ericli, petkov+cc_chromium.org
Base URL:
ssh://gitrw.chromium.org/autotest.git
Visibility:
Public.

Description

Relocate library files for wider access and re-use; also associated cleanup. Putting the factories in bin better matches other auotest files, and allows for better (simpler) access by both the control files and the ui. This in turn allows for us to avoid sending the TestData code definition between processes, which was very ugly. With all the code sharing libs, the logging function was also cleaned up. BUG=none TEST=suite_Factory

Patch Set 1 #

Patch Set 2 : nix the pexpect stuff that somehow crawled in #

Patch Set 3 : additional small Display cleanup #

Patch Set 4 : more stubs in control #

Patch Set 5 : fix typos #

Total comments: 1

Patch Set 6 : rebase -- no actual changes #

Patch Set 7 : address nicks comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+980 lines, -958 lines) Patch
A client/bin/factory.py View 1 chunk +101 lines, -0 lines 0 comments Download
A client/bin/factory_test.py View 1 2 1 chunk +110 lines, -0 lines 0 comments Download
A + client/bin/factory_ui View 22 chunks +54 lines, -77 lines 0 comments Download
D client/common_lib/factory_test.py View 1 chunk +0 lines, -94 lines 0 comments Download
D client/site_tests/factory_DeveloperRecovery/DevRecTest.py View 1 chunk +0 lines, -316 lines 0 comments Download
M client/site_tests/factory_DeveloperRecovery/factory_DeveloperRecovery.py View 1 chunk +311 lines, -24 lines 0 comments Download
M client/site_tests/factory_Display/factory_Display.py View 1 2 8 chunks +31 lines, -49 lines 0 comments Download
M client/site_tests/factory_Dummy/factory_Dummy.py View 2 chunks +21 lines, -16 lines 0 comments Download
M client/site_tests/factory_ExternalStorage/factory_ExternalStorage.py View 6 chunks +16 lines, -13 lines 0 comments Download
D client/site_tests/factory_Keyboard/KeyboardTest.py View 1 chunk +0 lines, -159 lines 0 comments Download
M client/site_tests/factory_Keyboard/factory_Keyboard.py View 2 chunks +148 lines, -13 lines 0 comments Download
A client/site_tests/factory_ScriptWrapper/dummy.sh View 1 chunk +7 lines, -0 lines 0 comments Download
M client/site_tests/factory_ScriptWrapper/factory_ScriptWrapper.py View 1 2 3 4 5 6 4 chunks +42 lines, -35 lines 0 comments Download
M client/site_tests/factory_Touchpad/factory_Touchpad.py View 9 chunks +26 lines, -21 lines 0 comments Download
M client/site_tests/suite_Factory/control View 1 2 3 4 5 6 6 chunks +113 lines, -141 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Tammo Spalink
10 years, 5 months ago (2010-06-30 04:38:03 UTC) #1
Nick Sanders
10 years, 5 months ago (2010-06-30 06:16:32 UTC) #2 
lgtm
Nice, it's much cleaner and easier to follow now!

http://codereview.chromium.org/2805052/diff/14001/15013
File client/site_tests/factory_ScriptWrapper/factory_ScriptWrapper.py (right):

http://codereview.chromium.org/2805052/diff/14001/15013#newcode33
client/site_tests/factory_ScriptWrapper/factory_ScriptWrapper.py:33: def
__init__(self, cmdline, pexpect, label):
is it necessary to pass pexpect here?

Powered by Google App Engine
This is Rietveld 408576698