Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(904)

Issue 2805045: Expand print-related IPCs so we can implement CSS3 paged media. (Closed)

Created:
10 years, 5 months ago by hamaji
Modified:
9 years, 5 months ago
Reviewers:
hayato, Yuzo
CC:
chromium-reviews, ben+cc_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org
Base URL:
git://codf21.jail/chromium.git
Visibility:
Public.

Description

Expand print-related IPCs so we can implement CSS3 paged media. The members added into ViewMsg_Print_Params will be used to tell printers' setting to renderer process. Maybe ViewMsg_Print_Params::printable_size should be printable_area, but I've just added margin_top and margin_left for now because printable_size is used from several code so I wanted to avoid a big change. The members added into ViewHostMsg_DidPrintPage_Params will be used to tell web authors' page setting to browser process. BUG=47277 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51117

Patch Set 1 #

Total comments: 2

Patch Set 2 : use page_size as suggested #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -4 lines) Patch
M chrome/browser/renderer_host/resource_message_filter.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/common/render_messages.h View 1 7 chunks +34 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
hamaji
10 years, 5 months ago (2010-06-29 09:31:22 UTC) #1
Yuzo
LGTM http://codereview.chromium.org/2805045/diff/1/2 File chrome/browser/renderer_host/resource_message_filter.cc (right): http://codereview.chromium.org/2805045/diff/1/2#newcode140 chrome/browser/renderer_host/resource_message_filter.cc:140: params->physical_size = settings.page_setup_device_units().physical_size(); I'm not sure, but perhaps ...
10 years, 5 months ago (2010-06-29 11:40:41 UTC) #2
hamaji
10 years, 5 months ago (2010-06-29 12:21:57 UTC) #3
http://codereview.chromium.org/2805045/diff/1/2
File chrome/browser/renderer_host/resource_message_filter.cc (right):

http://codereview.chromium.org/2805045/diff/1/2#newcode140
chrome/browser/renderer_host/resource_message_filter.cc:140:
params->physical_size = settings.page_setup_device_units().physical_size();
On 2010/06/29 11:40:41, Yuzo wrote:
> I'm not sure, but perhaps we should call it
>   page_size
> rather than
>   physical_size
> ?

Done.

Powered by Google App Engine
This is Rietveld 408576698