Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1250)

Unified Diff: net/spdy/spdy_session.h

Issue 2805039: SPDY: Make sure we don't try to send https/wss over an unauthenticated, but encrypted SSL socket. (Closed) Base URL: http://src.chromium.org/git/chromium.git
Patch Set: Propagate error codes. Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/spdy/spdy_network_transaction.cc ('k') | net/spdy/spdy_session.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_session.h
diff --git a/net/spdy/spdy_session.h b/net/spdy/spdy_session.h
index a46dad42950e594826e35153bf3d455eb70f0a9e..8a23168b9e5fac1f05711c566ee773a38bcce8f1 100644
--- a/net/spdy/spdy_session.h
+++ b/net/spdy/spdy_session.h
@@ -59,22 +59,25 @@ class SpdySession : public base::RefCounted<SpdySession>,
// Get a pushed stream for a given |url|.
// If the server initiates a stream, it might already exist for a given path.
// The server might also not have initiated the stream yet, but indicated it
- // will via X-Associated-Content.
- // Returns existing stream or NULL.
- scoped_refptr<SpdyStream> GetPushStream(
+ // will via X-Associated-Content. Writes the stream out to |spdy_stream|.
+ // Returns a net error code.
+ int GetPushStream(
const GURL& url,
+ scoped_refptr<SpdyStream>* spdy_stream,
const BoundNetLog& stream_net_log);
- // Create a new stream for a given |url|.
- // Returns the new stream. Never returns NULL.
- const scoped_refptr<SpdyStream>& CreateStream(
+ // Create a new stream for a given |url|. Writes it out to |spdy_stream|.
+ // Returns a net error code.
+ int CreateStream(
const GURL& url,
RequestPriority priority,
+ scoped_refptr<SpdyStream>* spdy_stream,
const BoundNetLog& stream_net_log);
// Used by SpdySessionPool to initialize with a pre-existing SSL socket.
// Returns OK on success, or an error on failure.
- net::Error InitializeWithSSLSocket(ClientSocketHandle* connection);
+ net::Error InitializeWithSSLSocket(ClientSocketHandle* connection,
+ int certificate_error_code);
// Send the SYN frame for |stream_id|.
int WriteSynStream(
@@ -251,6 +254,9 @@ class SpdySession : public base::RefCounted<SpdySession>,
// Flag if we're using an SSL connection for this SpdySession.
bool is_secure_;
+ // Certificate error code when using a secure connection.
+ int certificate_error_code_;
+
// Spdy Frame state.
spdy::SpdyFramer spdy_framer_;
« no previous file with comments | « net/spdy/spdy_network_transaction.cc ('k') | net/spdy/spdy_session.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698