Issue 2805034: Remove svn:executable from files in patched-yasm.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2805034: Remove svn:executable from files in patched-yasm. (Closed)

Created:
10 years, 6 months ago by Lei Zhang

Modified:
9 years, 7 months ago

Reviewers:
awong

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/deps/third_party/yasm/patched-yasm/

Visibility:
Public.

Description

Remove svn:executable from files in patched-yasm. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50870

Patch Set 1 #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs			Patch
M	modules/objfmts/bin/tests/bin-rip.asm	View	+-1 lines, --1 lines	0 comments	Download
M	modules/objfmts/elf/tests/elfmanysym.asm	View	+-1 lines, --1 lines	0 comments	Download
M	tools/re2c/mbo_getopt.h	View	+-1 lines, --1 lines	0 comments	Download
M	tools/re2c/mbo_getopt.c	View	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

awong

10 years, 6 months ago (2010-06-25 07:17:13 UTC) #2

LGTM

On Thu, Jun 24, 2010 at 10:42 PM, <thestig@chromium.org> wrote:

> Reviewers: awong,
>
> Description:
> Remove svn:executable from files in patched-yasm.
>
> BUG=none
> TEST=none
>
> Please review this at http://codereview.chromium.org/2805034/show
>
> SVN Base: svn://chrome-svn/chrome/trunk/deps/third_party/yasm/patched-yasm/
>
> Affected files:
>   M    modules/objfmts/bin/tests/bin-rip.asm
>   M    modules/objfmts/elf/tests/elfmanysym.asm
>   M    tools/re2c/mbo_getopt.h
>   M    tools/re2c/mbo_getopt.c
>
>
>
> Property changes on: modules/objfmts/bin/tests/bin-rip.asm
> ___________________________________________________________________
> Deleted: svn:executable
>   - *
>
>
> Property changes on: modules/objfmts/elf/tests/elfmanysym.asm
> ___________________________________________________________________
> Deleted: svn:executable
>   - *
>
>
> Property changes on: tools/re2c/mbo_getopt.c
> ___________________________________________________________________
> Deleted: svn:executable
>   - *
>
>
> Property changes on: tools/re2c/mbo_getopt.h
> ___________________________________________________________________
> Deleted: svn:executable
>   - *
>
>
>
>

Expand Messages | Collapse Messages