Issue 2805022: Tiny bit of clean up and follow new script naming convention.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2805022: Tiny bit of clean up and follow new script naming convention. (Closed)

Created:
10 years, 6 months ago by sosa

Modified:
9 years, 6 months ago

Reviewers:
davidjames

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
ssh://git@chromiumos-git//crosutils.git

Visibility:
Public.

Description

Tiny bit of clean up and follow new script naming convention. TEST=Re-ran script and downloaded latest image.

Patch Set 1 #

Patch Set 2 : git mv history didn't reset correctly #

Patch Set 3 : Fix double period. #

Total comments: 1

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -7 lines)			Patch
	A +	cros_download_latest_image	View	2	3 chunks	+5 lines, -7 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

davidjames

10 years, 6 months ago (2010-06-22 21:20:54 UTC) #2

Thanks for the cleanup. Please send an email to the list updating them on the
new name of the script.

LGTM w/nit

http://codereview.chromium.org/2805022/diff/5001/6001
File cros_download_latest_image (right):

http://codereview.chromium.org/2805022/diff/5001/6001#newcode38
cros_download_latest_image:38: die "Unrecognized board: $FLAGS_board" >&2
No need for >&2 here anymore, since you're using "die"

Expand Messages | Collapse Messages