Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Unified Diff: chrome/browser/memory_details.cc

Issue 28046: Use string for Histogram names since these are all ASCII anyway wide-characte... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/jankometer.cc ('k') | chrome/browser/metrics/metrics_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/memory_details.cc
===================================================================
--- chrome/browser/memory_details.cc (revision 10269)
+++ chrome/browser/memory_details.cc (working copy)
@@ -251,27 +251,27 @@
aggregate_memory += sample;
switch (browser.processes[index].type) {
case ChildProcessInfo::BROWSER_PROCESS:
- UMA_HISTOGRAM_MEMORY_KB(L"Memory.Browser", sample);
+ UMA_HISTOGRAM_MEMORY_KB("Memory.Browser", sample);
break;
case ChildProcessInfo::RENDER_PROCESS:
- UMA_HISTOGRAM_MEMORY_KB(L"Memory.Renderer", sample);
+ UMA_HISTOGRAM_MEMORY_KB("Memory.Renderer", sample);
break;
case ChildProcessInfo::PLUGIN_PROCESS:
- UMA_HISTOGRAM_MEMORY_KB(L"Memory.Plugin", sample);
+ UMA_HISTOGRAM_MEMORY_KB("Memory.Plugin", sample);
plugin_count++;
break;
case ChildProcessInfo::WORKER_PROCESS:
- UMA_HISTOGRAM_MEMORY_KB(L"Memory.Worker", sample);
+ UMA_HISTOGRAM_MEMORY_KB("Memory.Worker", sample);
worker_count++;
break;
}
}
- UMA_HISTOGRAM_COUNTS_100(L"Memory.ProcessCount",
+ UMA_HISTOGRAM_COUNTS_100("Memory.ProcessCount",
static_cast<int>(browser.processes.size()));
- UMA_HISTOGRAM_COUNTS_100(L"Memory.PluginProcessCount", plugin_count);
- UMA_HISTOGRAM_COUNTS_100(L"Memory.WorkerProcessCount", worker_count);
+ UMA_HISTOGRAM_COUNTS_100("Memory.PluginProcessCount", plugin_count);
+ UMA_HISTOGRAM_COUNTS_100("Memory.WorkerProcessCount", worker_count);
int total_sample = static_cast<int>(aggregate_memory / 1000);
- UMA_HISTOGRAM_MEMORY_MB(L"Memory.Total", total_sample);
+ UMA_HISTOGRAM_MEMORY_MB("Memory.Total", total_sample);
}
« no previous file with comments | « chrome/browser/jankometer.cc ('k') | chrome/browser/metrics/metrics_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698