Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2710)

Unified Diff: base/process_util_win.cc

Issue 28046: Use string for Histogram names since these are all ASCII anyway wide-characte... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/message_pump_win.cc ('k') | chrome/browser/autocomplete/history_contents_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/process_util_win.cc
===================================================================
--- base/process_util_win.cc (revision 10269)
+++ base/process_util_win.cc (working copy)
@@ -216,14 +216,14 @@
const int kLeastValue = 0;
const int kMaxValue = 0xFFF;
const int kBucketCount = kMaxValue - kLeastValue + 1;
- static LinearHistogram least_significant_histogram(L"ExitCodes.LSNibbles",
+ static LinearHistogram least_significant_histogram("ExitCodes.LSNibbles",
kLeastValue + 1, kMaxValue, kBucketCount);
least_significant_histogram.SetFlags(kUmaTargetedHistogramFlag |
LinearHistogram::kHexRangePrintingFlag);
least_significant_histogram.Add(exitcode & 0xFFF);
// Histogram the high order 3 nibbles
- static LinearHistogram most_significant_histogram(L"ExitCodes.MSNibbles",
+ static LinearHistogram most_significant_histogram("ExitCodes.MSNibbles",
kLeastValue + 1, kMaxValue, kBucketCount);
most_significant_histogram.SetFlags(kUmaTargetedHistogramFlag |
LinearHistogram::kHexRangePrintingFlag);
@@ -231,7 +231,7 @@
most_significant_histogram.Add((exitcode >> 20) & 0xFFF);
// Histogram the middle order 2 nibbles
- static LinearHistogram mid_significant_histogram(L"ExitCodes.MidNibbles",
+ static LinearHistogram mid_significant_histogram("ExitCodes.MidNibbles",
1, 0xFF, 0x100);
mid_significant_histogram.SetFlags(kUmaTargetedHistogramFlag |
LinearHistogram::kHexRangePrintingFlag);
« no previous file with comments | « base/message_pump_win.cc ('k') | chrome/browser/autocomplete/history_contents_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698