Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1095)

Unified Diff: net/disk_cache/entry_impl.cc

Issue 28046: Use string for Histogram names since these are all ASCII anyway wide-characte... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/disk_cache/block_files.cc ('k') | net/disk_cache/eviction.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/disk_cache/entry_impl.cc
===================================================================
--- net/disk_cache/entry_impl.cc (revision 10269)
+++ net/disk_cache/entry_impl.cc (working copy)
@@ -90,8 +90,8 @@
// written before).
EntryImpl::~EntryImpl() {
if (doomed_) {
- UMA_HISTOGRAM_COUNTS(L"DiskCache.DeleteHeader", GetDataSize(0));
- UMA_HISTOGRAM_COUNTS(L"DiskCache.DeleteData", GetDataSize(1));
+ UMA_HISTOGRAM_COUNTS("DiskCache.DeleteHeader", GetDataSize(0));
+ UMA_HISTOGRAM_COUNTS("DiskCache.DeleteData", GetDataSize(1));
for (int index = 0; index < NUM_STREAMS; index++) {
Addr address(entry_.Data()->data_addr[index]);
if (address.is_initialized()) {
@@ -211,7 +211,7 @@
return net::ERR_INVALID_ARGUMENT;
Time start = Time::Now();
- static Histogram stats(L"DiskCache.ReadTime", TimeDelta::FromMilliseconds(1),
+ static Histogram stats("DiskCache.ReadTime", TimeDelta::FromMilliseconds(1),
TimeDelta::FromSeconds(10), 50);
stats.SetFlags(kUmaTargetedHistogramFlag);
@@ -285,7 +285,7 @@
}
Time start = Time::Now();
- static Histogram stats(L"DiskCache.WriteTime", TimeDelta::FromMilliseconds(1),
+ static Histogram stats("DiskCache.WriteTime", TimeDelta::FromMilliseconds(1),
TimeDelta::FromSeconds(10), 50);
stats.SetFlags(kUmaTargetedHistogramFlag);
@@ -557,7 +557,7 @@
files_[index] = NULL; // Releases the object.
if (!DeleteCacheFile(backend_->GetFileName(address))) {
- UMA_HISTOGRAM_COUNTS(L"DiskCache.DeleteFailed", 1);
+ UMA_HISTOGRAM_COUNTS("DiskCache.DeleteFailed", 1);
LOG(ERROR) << "Failed to delete " << backend_->GetFileName(address) <<
" from the cache.";
}
@@ -785,4 +785,3 @@
}
} // namespace disk_cache
-
« no previous file with comments | « net/disk_cache/block_files.cc ('k') | net/disk_cache/eviction.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698