Issue 2804018: [Mac] filp file on disk encoding to UTF-8 to avoid build warnings....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2804018: [Mac] filp file on disk encoding to UTF-8 to avoid build warnings.... (Closed)

Created:
10 years, 6 months ago by TVL

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews, darin-cc_chromium.org, dpranke+watch_chromium.org, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

[Mac] filp file on disk encoding to UTF-8 to avoid build warnings. BUG=38443 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50591

Patch Set 1 #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -0 lines)			Patch
	MM	webkit/tools/test_shell/mac/English.lproj/InfoPlist.strings	View		Binary file		0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

TVL

Here's the manual diff: Index: webkit/tools/test_shell/mac/English.lproj/InfoPlist.strings =================================================================== Cannot display: file marked as a binary type. ...

10 years, 6 months ago (2010-06-23 12:31:31 UTC) #1

LGTM

Expand Messages | Collapse Messages