chrome/browser/app_modal_dialog_win.cc - Issue 2803017: Fix a crash when we try to close a js dialog that wasn't shown.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/app_modal_dialog_win.cc

Issue 2803017: Fix a crash when we try to close a js dialog that wasn't shown. (Closed) Base URL: http://src.chromium.org/git/chromium.git

Patch Set: Created 10 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/app_modal_dialog_win.cc

diff --git a/chrome/browser/app_modal_dialog_win.cc b/chrome/browser/app_modal_dialog_win.cc

index c892881d027df5740258dba1d55b857c5eb20add..e48d9862bc1cf9a86e6bde6592d14aea6822cef9 100644

--- a/chrome/browser/app_modal_dialog_win.cc

+++ b/chrome/browser/app_modal_dialog_win.cc

@@ -19,9 +19,11 @@ void AppModalDialog::CreateAndShowDialog() {

}

void AppModalDialog::ActivateModalDialog() {

+ DCHECK(dialog_);

dialog_->ActivateModalDialog();

}

void AppModalDialog::CloseModalDialog() {

+ DCHECK(dialog_);

dialog_->CloseModalDialog();

}

« no previous file with comments | « chrome/browser/app_modal_dialog_gtk.cc ('k') | chrome/browser/js_modal_dialog.cc » ('j') | no next file with comments »