Issue 2803005: Reland: Client side changes to set and get nigori specifics with passing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2803005: Reland: Client side changes to set and get nigori specifics with passing (Closed)

Created:
10 years, 6 months ago by albertb

Modified:
9 years, 3 months ago

Reviewers:
chron_chromium.org

CC:
chromium-reviews, ncarter (slow), ben+cc_chromium.org, tim (not reviewing), idana

Visibility:
Public.

Description

Reland: Client side changes to set and get nigori specifics with passing sync_unit_tests. BUG=none TEST=sync_unit_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50015

Patch Set 1 #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+39 lines, -0 lines)			Patch
M	chrome/browser/sync/engine/syncapi.h	View	4 chunks	+11 lines, -0 lines	0 comments	Download
M	chrome/browser/sync/engine/syncapi.cc	View	3 chunks	+19 lines, -0 lines	0 comments	Download
M	chrome/browser/sync/syncable/model_type.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/sync/syncable/model_type.cc	View	3 chunks	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

chron

10 years, 6 months ago (2010-06-16 18:36:22 UTC) #2

LGTM assuming trybots pass.

On Wed, Jun 16, 2010 at 11:33 AM, <albertb@chromium.org> wrote:

> Reviewers: chron_chromium.org,
>
> Description:
> Reland: Client side changes to set and get nigori specifics with passing
> sync_unit_tests.
>
> BUG=none
> TEST=sync_unit_tests
>
> Please review this at http://codereview.chromium.org/2803005/show
>
> Affected files:
>  M chrome/browser/sync/engine/syncapi.h
>  M chrome/browser/sync/engine/syncapi.cc
>  M chrome/browser/sync/syncable/model_type.h
>  M chrome/browser/sync/syncable/model_type.cc
>
>
>

Expand Messages | Collapse Messages