Cascading menus change growth dirction (right or left) when we hit the...

Cascading menus change growth dirction (right or left) when we hit the
side of the screen.

BUG=42808
TEST=Add a 100-level deep list of folders (or whatever).  
Open them --> grow to the right until side of the screen.
Keep opening subfolders --> starts growing to the left.
Keep going until left side of screen --> grows right again.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51622

[John Grabowski, 2010-06-30 23:36:36]

cc thakis since this bug made THAKIS SMASH

[Nico, 2010-06-30 23:45:46]

RAAAAAAAAAAAGE

http://codereview.chromium.org/2802025/diff/1/2
File chrome/browser/cocoa/bookmark_bar_folder_controller.h (right):

http://codereview.chromium.org/2802025/diff/1/2#newcode159
chrome/browser/cocoa/bookmark_bar_folder_controller.h:159: @property (assign,
nonatomic) BOOL subFolderGrowthToRight;
it's "nonatomic, assing" in most files

http://codereview.chromium.org/2802025/diff/1/3
File chrome/browser/cocoa/bookmark_bar_folder_controller.mm (right):

http://codereview.chromium.org/2802025/diff/1/3#newcode158
chrome/browser/cocoa/bookmark_bar_folder_controller.mm:158: -
(void)resetSubFolderGrowthDirection {
nit: this method seems like overkill

http://codereview.chromium.org/2802025/diff/1/3#newcode295
chrome/browser/cocoa/bookmark_bar_folder_controller.mm:295: while (tries < 3) {
do you change |[parentButton_ window] frame| in this loop? if not, why would
this loop not do the same thing 3 times?

http://codereview.chromium.org/2802025/diff/1/3#newcode306
chrome/browser/cocoa/bookmark_bar_folder_controller.mm:306: break;
return x;

http://codereview.chromium.org/2802025/diff/1/3#newcode319
chrome/browser/cocoa/bookmark_bar_folder_controller.mm:319: break;
return x;

http://codereview.chromium.org/2802025/diff/1/3#newcode325
chrome/browser/cocoa/bookmark_bar_folder_controller.mm:325: if (tries == 3)
remove if, return NSMaxX

[John Grabowski, 2010-07-01 00:05:09]

smashboy's feedback applied

http://codereview.chromium.org/2802025/diff/1/2
File chrome/browser/cocoa/bookmark_bar_folder_controller.h (right):

http://codereview.chromium.org/2802025/diff/1/2#newcode159
chrome/browser/cocoa/bookmark_bar_folder_controller.h:159: @property (assign,
nonatomic) BOOL subFolderGrowthToRight;
On 2010/06/30 23:45:46, Nico wrote:
> it's "nonatomic, assing" in most files

Hmm.  


/Volumes/work/chrome/src/chrome/browser/cocoa
superdee:cocoa jrg$ grep '(nonatomic' *.h | wc -l
      79
superdee:cocoa jrg$ grep 'nonatomic)' *.h | wc -l
      88

http://codereview.chromium.org/2802025/diff/1/3
File chrome/browser/cocoa/bookmark_bar_folder_controller.mm (right):

http://codereview.chromium.org/2802025/diff/1/3#newcode158
chrome/browser/cocoa/bookmark_bar_folder_controller.mm:158: -
(void)resetSubFolderGrowthDirection {
On 2010/06/30 23:45:46, Nico wrote:
> nit: this method seems like overkill

removed

http://codereview.chromium.org/2802025/diff/1/3#newcode295
chrome/browser/cocoa/bookmark_bar_folder_controller.mm:295: while (tries < 3) {
On 2010/06/30 23:45:46, Nico wrote:
> do you change |[parentButton_ window] frame| in this loop? if not, why would
> this loop not do the same thing 3 times?

Depending on growth direction we may try growRight or growLeft first.  If we try
growLeft first (![self subFolderGrowthToRight]) we must loop on the while to try
again.

Simplified.

[feldstein, 2010-07-01 00:29:08]

LGTM

[dhollowa, 2010-07-01 19:59:24]

LGTM.