Massively simplify the NetworkChangeNotifier infrastructure:...

net/http/http_network_layer.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_HTTP_HTTP_NETWORK_LAYER_H_
 #define NET_HTTP_HTTP_NETWORK_LAYER_H_
 
 #include <string>
 
 #include "base/ref_counted.h"
 #include "base/scoped_ptr.h"
 #include "net/http/http_transaction_factory.h"
 
 namespace net {
 
 class ClientSocketFactory;
 class HostResolver;
 class HttpAuthHandlerFactory;
 class HttpNetworkDelegate;
 class HttpNetworkSession;
 class NetLog;
-class NetworkChangeNotifier;
 class ProxyInfo;
 class ProxyService;
 class SpdySessionPool;
 class SSLConfigService;
 
 class HttpNetworkLayer : public HttpTransactionFactory {
  public:
-  // |socket_factory|, |network_change_notifier|, |proxy_service| and
-  // |host_resolver| must remain valid for the lifetime of HttpNetworkLayer.
+  // |socket_factory|, |proxy_service| and |host_resolver| must remain valid for
+  // the lifetime of HttpNetworkLayer.
   HttpNetworkLayer(ClientSocketFactory* socket_factory,
-                   NetworkChangeNotifier* network_change_notifier,
-                   HostResolver* host_resolver, ProxyService* proxy_service,
+                   HostResolver* host_resolver,
+                   ProxyService* proxy_service,
                    SSLConfigService* ssl_config_service,
                    HttpAuthHandlerFactory* http_auth_handler_factory,
                    HttpNetworkDelegate* network_delegate,
                    NetLog* net_log);
   // Construct a HttpNetworkLayer with an existing HttpNetworkSession which
   // contains a valid ProxyService.
   explicit HttpNetworkLayer(HttpNetworkSession* session);
   ~HttpNetworkLayer();
 
   // This function hides the details of how a network layer gets instantiated
   // and allows other implementations to be substituted.
   static HttpTransactionFactory* CreateFactory(
-      NetworkChangeNotifier* network_change_notifier,
       HostResolver* host_resolver,
       ProxyService* proxy_service,
       SSLConfigService* ssl_config_service,
       HttpAuthHandlerFactory* http_auth_handler_factory,
       HttpNetworkDelegate* network_delegate,
       NetLog* net_log);
   // Create a transaction factory that instantiate a network layer over an
   // existing network session. Network session contains some valuable
   // information (e.g. authentication data) that we want to share across
   // multiple network layers. This method exposes the implementation details
@@ skipping 12 matching lines @@
   //   ""            : (default) SSL and compression are enabled.
   //   "no-ssl"      : disables SSL.
   //   "no-compress" : disables compression.
   //   "none"        : disables both SSL and compression.
   static void EnableSpdy(const std::string& mode);
 
  private:
   // The factory we will use to create network sockets.
   ClientSocketFactory* socket_factory_;
 
-  NetworkChangeNotifier* network_change_notifier_;
-
   // The host resolver and proxy service that will be used when lazily
   // creating |session_|.
   scoped_refptr<HostResolver> host_resolver_;
   scoped_refptr<ProxyService> proxy_service_;
 
   // The SSL config service being used for the session.
   scoped_refptr<SSLConfigService> ssl_config_service_;
 
   scoped_refptr<HttpNetworkSession> session_;
   scoped_refptr<SpdySessionPool> spdy_session_pool_;
 
   HttpAuthHandlerFactory* http_auth_handler_factory_;
   HttpNetworkDelegate* network_delegate_;
   NetLog* net_log_;
 
   bool suspended_;
   static bool force_spdy_;
 };
 
 }  // namespace net
 
 #endif  // NET_HTTP_HTTP_NETWORK_LAYER_H_