Issue 2802006: Fix the error found by -Wextra, disable part of the test because it doesn't s...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2802006: Fix the error found by -Wextra, disable part of the test because it doesn't s... (Closed)

Created:
10 years, 6 months ago by TVL

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Fix the error found by -Wextra, disable part of the test because it doesn't seem like it ever would have passed in the first place. BUG=46663 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49941

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -4 lines)			Patch
	M	chrome/browser/cocoa/translate_infobar.mm	View	1	4 chunks	+24 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

10 years, 6 months ago (2010-06-16 13:32:02 UTC) #2

LG with comments englished.

http://codereview.chromium.org/2802006/diff/1/2
File chrome/browser/cocoa/translate_infobar.mm (right):

http://codereview.chromium.org/2802006/diff/1/2#newcode74
chrome/browser/cocoa/translate_infobar.mm:74: // is going to be zero by
Objective-C runtime).
what is “zero by Objective-C runtime?”

http://codereview.chromium.org/2802006/diff/1/2#newcode787
chrome/browser/cocoa/translate_infobar.mm:787: // bug was fixed in
VerifyControlOrderAndSpacing this never passes.  Scanning
Nobody’s going to know what the “unsigned >= 0” bug was with respect to that
function once you check this in.

You can repeat here that VCOAS is broken.

Expand Messages | Collapse Messages