Source/core/dom/ChildListMutationScope.cpp - Issue 280123002: Oilpan: move LiveNodeList collections to the heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/ChildListMutationScope.cpp

Issue 280123002: Oilpan: move LiveNodeList collections to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Have NodeRareData clear out NodeListsNodeData instead. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/dom/ChildListMutationScope.cpp

diff --git a/Source/core/dom/ChildListMutationScope.cpp b/Source/core/dom/ChildListMutationScope.cpp

index cce9f6bebc756a792feb3b3348ea43677fcd32d8..85f38f340f62f81e81b19856cfd16aa113e293a7 100644

--- a/Source/core/dom/ChildListMutationScope.cpp

+++ b/Source/core/dom/ChildListMutationScope.cpp

@@ -126,8 +126,8 @@ void ChildListMutationAccumulator::enqueueMutationRecord()

ASSERT(hasObservers());

ASSERT(!isEmpty());

- RefPtr<NodeList> addedNodes = StaticNodeList::adopt(m_addedNodes);

- RefPtr<NodeList> removedNodes = StaticNodeList::adopt(m_removedNodes);

+ RefPtrWillBeRawPtr<NodeList> addedNodes = StaticNodeList::adopt(m_addedNodes);

+ RefPtrWillBeRawPtr<NodeList> removedNodes = StaticNodeList::adopt(m_removedNodes);

RefPtrWillBeRawPtr<MutationRecord> record = MutationRecord::createChildList(m_target, addedNodes.release(), removedNodes.release(), m_previousSibling.release(), m_nextSibling.release());

m_observers->enqueueMutationRecord(record.release());

m_lastAdded = 0;

« no previous file with comments | « Source/core/accessibility/AXTable.cpp ('k') | Source/core/dom/ChildNodeList.h » ('j') | no next file with comments »