Source/bindings/tests/results/V8TestSpecialOperations.cpp - Issue 280123002: Oilpan: move LiveNodeList collections to the heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/V8TestSpecialOperations.cpp

Issue 280123002: Oilpan: move LiveNodeList collections to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Have NodeRareData clear out NodeListsNodeData instead. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/tests/results/V8TestSpecialOperations.cpp

diff --git a/Source/bindings/tests/results/V8TestSpecialOperations.cpp b/Source/bindings/tests/results/V8TestSpecialOperations.cpp

index ad127bbf579ef951c9e10860b405e5a4fb85f8e0..def0c5852c3ab0ef7ac4fe44917a1e84c972902a 100644

--- a/Source/bindings/tests/results/V8TestSpecialOperations.cpp

+++ b/Source/bindings/tests/results/V8TestSpecialOperations.cpp

@@ -55,7 +55,7 @@ static void namedItemMethod(const v8::FunctionCallbackInfo<v8::Value>& info)

bool result0Enabled = false;

RefPtr<Node> result0;

bool result1Enabled = false;

- RefPtr<NodeList> result1;

+ RefPtrWillBeRawPtr<NodeList> result1;

impl->getItem(name, result0Enabled, result0, result1Enabled, result1);

if (result0Enabled) {

v8SetReturnValue(info, result0.release());

@@ -82,7 +82,7 @@ static void namedPropertyGetter(v8::Local<v8::String> name, const v8::PropertyCa

bool result0Enabled = false;

RefPtr<Node> result0;

bool result1Enabled = false;

- RefPtr<NodeList> result1;

+ RefPtrWillBeRawPtr<NodeList> result1;

impl->getItem(propertyName, result0Enabled, result0, result1Enabled, result1);

if (!result0Enabled && !result1Enabled)

return;

« no previous file with comments | « no previous file | Source/bindings/v8/V8WindowShell.cpp » ('j') | no next file with comments »