Issue 2801019: No actual code change. Just added more logging information to help...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2801019: No actual code change. Just added more logging information to help... (Closed)

Created:
10 years, 6 months ago by gene

Modified:
9 years, 6 months ago

Reviewers:
sanjeevr

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

No actual code change. Just added more logging information to help debugging cloud print proxy in the production environment. BUG=none TEST=Run cloud print proxy with --log-filter-prefix="CP_PROXY" and verify new information get logged. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51066

Patch Set 1 #

Total comments: 1

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -5 lines)			Patch
	M	chrome/service/cloud_print/cloud_print_proxy_backend.cc	View		10 chunks	+12 lines, -2 lines	1 comment	Download
	M	chrome/service/cloud_print/printer_job_handler.cc	View		21 chunks	+32 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sanjeevr

10 years, 6 months ago (2010-06-25 20:39:42 UTC) #2

LGTM

http://codereview.chromium.org/2801019/diff/1/2
File chrome/service/cloud_print/cloud_print_proxy_backend.cc (right):

http://codereview.chromium.org/2801019/diff/1/2#newcode343
chrome/service/cloud_print/cloud_print_proxy_backend.cc:343: LOG(INFO) <<
"CP_PROXY: Shutdown proxy.";
Trace proxy id here as well

Expand Messages | Collapse Messages