Issue 2801017: sqlite_utils: don't dereference an empty vector.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2801017: sqlite_utils: don't dereference an empty vector. (Closed)

Created:
10 years, 6 months ago by ncarter (slow)

Modified:
9 years, 7 months ago

Reviewers:
tim (not reviewing)

CC:
chromium-reviews, Paweł Hajdan Jr., ncarter (slow), ben+cc_chromium.org, tim (not reviewing), idana

Visibility:
Public.

Description

sqlite_utils: don't dereference an empty vector. user_settings: Add unit test intended to exercise the above path. In practice though these tests don't hit the bug, since EncryptData("") results in non-empty ciphertext. bonus: don't leak a sqlite handle in one of the other sync unit tests. TEST=none BUG=40217

Patch Set 1 #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+36 lines, -6 lines)			Patch
M	chrome/browser/sync/util/data_encryption.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/sync/util/user_settings_unittest.cc	View	8 chunks	+33 lines, -4 lines	0 comments	Download
M	chrome/common/sqlite_utils.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

ncarter (slow)

Hi Tim, Kindly review. I can add a sqlite_utils_unittest if you like.

10 years, 6 months ago (2010-06-24 01:29:13 UTC) #1

nice
LGTM

Expand Messages | Collapse Messages