Chromium Code Reviews

Issue 2801003: Tighten up compile warnings based to match other chromium sub-projects.... (Closed)

Created:
10 years, 6 months ago by dmac
Modified:
9 years, 7 months ago
Reviewers:
Sergey Ulanov, TVL, awong, Alpha Left Google
CC:
chromium-reviews, Alpha Left Google, dmac, awong, garykac, Paweł Hajdan Jr.
Visibility:
Public.

Description

Tighten up compile warnings based to match other chromium sub-projects. Fix up the issues that the new warnings raised. BUG=none TEST=build remoting cleanly Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49842

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Total comments: 1

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Stats (+31 lines, -33 lines)
M remoting/base/multiple_array_input_stream_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments
M remoting/base/protocol_decoder.h View 1 chunk +3 lines, -3 lines 0 comments
M remoting/base/protocol_decoder.cc View 3 chunks +4 lines, -5 lines 0 comments
M remoting/client/plugin/chromoting_plugin.cc View 1 chunk +0 lines, -1 line 0 comments
M remoting/client/plugin/chromoting_plugin_unittest.cc View 1 chunk +0 lines, -5 lines 0 comments
M remoting/client/plugin/client.cc View 1 chunk +0 lines, -1 line 0 comments
M remoting/client/plugin/compression.cc View 1 chunk +1 line, -0 lines 0 comments
M remoting/host/client_connection.cc View 1 chunk +1 line, -1 line 0 comments
M remoting/host/differ_unittest.cc View 7 chunks +7 lines, -7 lines 0 comments
M remoting/host/encoder_verbatim.cc View 1 chunk +0 lines, -2 lines 0 comments
M remoting/host/session_manager.cc View 2 chunks +2 lines, -2 lines 0 comments
M remoting/jingle_glue/jingle_channel.cc View 1 chunk +1 line, -1 line 0 comments
M remoting/jingle_glue/jingle_client.cc View 1 chunk +3 lines, -0 lines 0 comments
M remoting/jingle_glue/jingle_thread.cc View 1 chunk +3 lines, -3 lines 0 comments
M remoting/remoting.gyp View 1 chunk +4 lines, -0 lines 0 comments

Messages

Total messages: 9 (0 generated)
dmac
This makes us equivalent with other chromium subprojects in terms of warning level.
10 years, 6 months ago (2010-06-15 17:13:30 UTC) #1
awong
Yikes. We've been slacking in our code. Thanks for fixing! I thought we had -Werror ...
10 years, 6 months ago (2010-06-15 17:20:23 UTC) #2
TVL
lgtm http://codereview.chromium.org/2801003/diff/17001/8016 File remoting/remoting.gyp (right): http://codereview.chromium.org/2801003/diff/17001/8016#newcode12 remoting/remoting.gyp:12: ], drop this while here?
10 years, 6 months ago (2010-06-15 17:28:04 UTC) #3
Sergey Ulanov
http://codereview.chromium.org/2801003/diff/1/14 File remoting/jingle_glue/jingle_client.cc (right): http://codereview.chromium.org/2801003/diff/1/14#newcode182 remoting/jingle_glue/jingle_client.cc:182: case buzz::XmppEngine::STATE_NONE: On 2010/06/15 17:20:23, awong wrote: > Should ...
10 years, 6 months ago (2010-06-15 17:45:49 UTC) #4
dmac
http://codereview.chromium.org/2801003/diff/1/14 File remoting/jingle_glue/jingle_client.cc (right): http://codereview.chromium.org/2801003/diff/1/14#newcode182 remoting/jingle_glue/jingle_client.cc:182: case buzz::XmppEngine::STATE_NONE: On 2010/06/15 17:45:50, sergeyu wrote: > On ...
10 years, 6 months ago (2010-06-15 18:27:45 UTC) #5
Sergey Ulanov
LGTM. Why don't we use -Wall by default?
10 years, 6 months ago (2010-06-15 20:04:28 UTC) #6
TVL
On Tue, Jun 15, 2010 at 4:04 PM, <sergeyu@chromium.org> wrote: > LGTM. > Why don't ...
10 years, 6 months ago (2010-06-15 20:05:55 UTC) #7
awong
LGTM Ah..so with chromium_code:1, we should get -Wall right?
10 years, 6 months ago (2010-06-15 20:07:01 UTC) #8
TVL
10 years, 6 months ago (2010-06-15 20:08:35 UTC) #9 
On Tue, Jun 15, 2010 at 4:07 PM, <ajwong@chromium.org> wrote:

> LGTM
>
> Ah..so with chromium_code:1, we should get -Wall right?


y, see build/common.gypi for that it triggers.

TVL


>
>
> http://codereview.chromium.org/2801003/show
>

Powered by Google App Engine