Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 2800044: Fix crash introduced in r5019.... (Closed)

Created:
10 years, 5 months ago by Vladislav Kaznacheev
Modified:
9 years, 7 months ago
Reviewers:
Vitaly Repeshko
CC:
v8-dev
Visibility:
Public.

Description

Fix crash introduced in r5019. Note to self: never leave uninitialized objects in the code space. Committed: http://code.google.com/p/v8/source/detail?r=5029

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M src/heap.cc View 1 4 chunks +10 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Vladislav Kaznacheev
10 years, 5 months ago (2010-07-06 13:31:50 UTC) #1
Vitaly Repeshko
LGTM http://codereview.chromium.org/2800044/diff/1/2 File src/heap.cc (right): http://codereview.chromium.org/2800044/diff/1/2#newcode2354 src/heap.cc:2354: Object* reloc_info = AllocateByteArray(desc.reloc_size, TENURED); Please add a ...
10 years, 5 months ago (2010-07-06 13:39:35 UTC) #2
Vladislav Kaznacheev
10 years, 5 months ago (2010-07-06 13:48:10 UTC) #3
Vladislav Kaznacheev
10 years, 5 months ago (2010-07-06 13:48:17 UTC) #4
http://codereview.chromium.org/2800044/diff/1/2
File src/heap.cc (right):

http://codereview.chromium.org/2800044/diff/1/2#newcode2354
src/heap.cc:2354: Object* reloc_info = AllocateByteArray(desc.reloc_size,
TENURED);
On 2010/07/06 13:39:35, Vitaly wrote:
> Please add a note that this mustn't be put in the middle of code object
creation
> because leaving an uninitialized code object (no map and sizes) breaks the
code
> space. 

Done.

Powered by Google App Engine
This is Rietveld 408576698