Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 2800039: ibus-hangul: Use Ctrl+Alt+F9 as a Hanja hot-key instead of F9. (Closed)

Created:
10 years, 5 months ago by Yusuke Sato
Modified:
9 years, 7 months ago
CC:
chromium-reviews, davemoore+watch_chromium.org, ben+cc_chromium.org, mazda, satorux1
Visibility:
Public.

Description

ibus-hangul: Use Ctrl+Alt+F9 as a Hanja hot-key instead of F9. Since F9 is reserved by the window manager on Chrome OS. BUG=chromium-os:4319 TEST=manually Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51654

Patch Set 1 : review #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M chrome/browser/chromeos/language_preferences.h View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/preferences.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/preferences.cc View 1 3 chunks +7 lines, -0 lines 0 comments Download
M chrome/common/pref_names.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/pref_names.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Yusuke Sato
10 years, 5 months ago (2010-07-05 02:51:24 UTC) #1
Zachary Kuznia
10 years, 5 months ago (2010-07-05 07:13:45 UTC) #2
LGTM

This should break the desktopui_IBusTest in autotest.

Powered by Google App Engine
This is Rietveld 408576698