Issue 2800029: PyAuto: Collect branding info as a part of GetBrowserInfo()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2800029: PyAuto: Collect branding info as a part of GetBrowserInfo() (Closed)

Created:
10 years, 5 months ago by Nirnimesh

Modified:
9 years, 7 months ago

Reviewers:
John Grabowski

CC:
chromium-reviews, ben+cc_chromium.org, Paweł Hajdan Jr.

Visibility:
Public.

Description

PyAuto: Collect branding info as a part of GetBrowserInfo() Also, use command_line_string() from base/command_line.h which is cross-platform now. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51055

Patch Set 1 #

Patch Set 2 : . #

Total comments: 1

Patch Set 3 : . #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -5 lines)			Patch
	M	chrome/browser/automation/automation_provider.cc	View	1 2	1 chunk	+9 lines, -4 lines	0 comments	Download
	M	chrome/test/pyautolib/pyauto.py	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

John Grabowski

10 years, 5 months ago (2010-06-28 21:26:44 UTC) #2

LGTM with branding change

http://codereview.chromium.org/2800029/diff/2001/3001
File chrome/browser/automation/automation_provider.cc (right):

http://codereview.chromium.org/2800029/diff/2001/3001#newcode1653
chrome/browser/automation/automation_provider.cc:1653: #error Unknown branding
Would prefer "Unknown Branding" since Chrome is known to be compiled with other
brands (e.g. Iron).  Best to not break them.

Expand Messages | Collapse Messages