Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(636)

Unified Diff: webkit/glue/plugins/pepper_resource_tracker.h

Issue 2800028: Simplfy Pepepr2 bolierplate code. (Closed) Base URL: http://src.chromium.org/git/chromium.git
Patch Set: Updated. Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/glue/plugins/pepper_resource_tracker.h
diff --git a/webkit/glue/plugins/pepper_resource_tracker.h b/webkit/glue/plugins/pepper_resource_tracker.h
index cfe2e685e9e72db9600c4496609074f0ce80fa77..35c382d72805421ef0a51561b00cc4f0ef9633ba 100644
--- a/webkit/glue/plugins/pepper_resource_tracker.h
+++ b/webkit/glue/plugins/pepper_resource_tracker.h
@@ -16,17 +16,7 @@
namespace pepper {
-class Buffer;
-class DeviceContext2D;
-class DirectoryReader;
-class FileChooser;
-class FileIO;
-class FileRef;
-class ImageData;
class Resource;
-class URLLoader;
-class URLRequestInfo;
-class URLResponseInfo;
// This class maintains a global list of all live pepper resources. It allows
// us to check resource ID validity and to map them to a specific module.
@@ -39,7 +29,7 @@ class ResourceTracker {
// The returned pointer will be NULL if there is no resource. Note that this
// return value is a scoped_refptr so that we ensure the resource is valid
- // from the point of the loopkup to the point that the calling code needs it.
+ // from the point of the lookup to the point that the calling code needs it.
// Otherwise, the plugin could Release() the resource on another thread and
// the object will get deleted out from under us.
scoped_refptr<Resource> GetResource(PP_Resource res) const;
@@ -50,19 +40,6 @@ class ResourceTracker {
void DeleteResource(Resource* resource);
- // Helpers for converting resources to a specific type. Returns NULL if the
- // resource is invalid or is a different type.
- scoped_refptr<Buffer> GetAsBuffer(PP_Resource res) const;
- scoped_refptr<DeviceContext2D> GetAsDeviceContext2D(PP_Resource res) const;
- scoped_refptr<DirectoryReader> GetAsDirectoryReader(PP_Resource res) const;
- scoped_refptr<FileChooser> GetAsFileChooser(PP_Resource res) const;
- scoped_refptr<FileIO> GetAsFileIO(PP_Resource res) const;
- scoped_refptr<FileRef> GetAsFileRef(PP_Resource res) const;
- scoped_refptr<ImageData> GetAsImageData(PP_Resource res) const;
- scoped_refptr<URLLoader> GetAsURLLoader(PP_Resource res) const;
- scoped_refptr<URLRequestInfo> GetAsURLRequestInfo(PP_Resource res) const;
- scoped_refptr<URLResponseInfo> GetAsURLResponseInfo(PP_Resource res) const;
-
private:
friend struct DefaultSingletonTraits<ResourceTracker>;

Powered by Google App Engine
This is Rietveld 408576698