Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Side by Side Diff: webkit/glue/plugins/pepper_directory_reader.cc

Issue 2800028: Simplfy Pepepr2 bolierplate code. (Closed) Base URL: http://src.chromium.org/git/chromium.git
Patch Set: Updated. Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "webkit/glue/plugins/pepper_directory_reader.h" 5 #include "webkit/glue/plugins/pepper_directory_reader.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "third_party/ppapi/c/pp_completion_callback.h" 8 #include "third_party/ppapi/c/pp_completion_callback.h"
9 #include "third_party/ppapi/c/pp_errors.h" 9 #include "third_party/ppapi/c/pp_errors.h"
10 #include "webkit/glue/plugins/pepper_file_ref.h" 10 #include "webkit/glue/plugins/pepper_file_ref.h"
11 #include "webkit/glue/plugins/pepper_resource_tracker.h" 11 #include "webkit/glue/plugins/pepper_resource_tracker.h"
12 12
13 namespace pepper { 13 namespace pepper {
14 14
15 namespace { 15 namespace {
16 16
17 PP_Resource Create(PP_Resource directory_ref_id) { 17 PP_Resource Create(PP_Resource directory_ref_id) {
18 scoped_refptr<FileRef> directory_ref( 18 scoped_refptr<FileRef> directory_ref(
19 ResourceTracker::Get()->GetAsFileRef(directory_ref_id)); 19 Resource::GetAs<FileRef>(directory_ref_id));
20 if (!directory_ref.get()) 20 if (!directory_ref.get())
21 return 0; 21 return 0;
22 22
23 DirectoryReader* reader = new DirectoryReader(directory_ref); 23 DirectoryReader* reader = new DirectoryReader(directory_ref);
24 reader->AddRef(); // AddRef for the caller; 24 reader->AddRef(); // AddRef for the caller;
25 return reader->GetResource(); 25 return reader->GetResource();
26 } 26 }
27 27
28 bool IsDirectoryReader(PP_Resource resource) { 28 bool IsDirectoryReader(PP_Resource resource) {
29 return !!ResourceTracker::Get()->GetAsDirectoryReader(resource).get(); 29 return !!Resource::GetAs<DirectoryReader>(resource).get();
30 } 30 }
31 31
32 int32_t GetNextEntry(PP_Resource reader_id, 32 int32_t GetNextEntry(PP_Resource reader_id,
33 PP_DirectoryEntry* entry, 33 PP_DirectoryEntry* entry,
34 PP_CompletionCallback callback) { 34 PP_CompletionCallback callback) {
35 scoped_refptr<DirectoryReader> reader( 35 scoped_refptr<DirectoryReader> reader(
36 ResourceTracker::Get()->GetAsDirectoryReader(reader_id)); 36 Resource::GetAs<DirectoryReader>(reader_id));
37 if (!reader.get()) 37 if (!reader.get())
38 return PP_Error_BadResource; 38 return PP_Error_BadResource;
39 39
40 return reader->GetNextEntry(entry, callback); 40 return reader->GetNextEntry(entry, callback);
41 } 41 }
42 42
43 const PPB_DirectoryReader ppb_directoryreader = { 43 const PPB_DirectoryReader ppb_directoryreader = {
44 &Create, 44 &Create,
45 &IsDirectoryReader, 45 &IsDirectoryReader,
46 &GetNextEntry 46 &GetNextEntry
(...skipping 13 matching lines...) Expand all
60 return &ppb_directoryreader; 60 return &ppb_directoryreader;
61 } 61 }
62 62
63 int32_t DirectoryReader::GetNextEntry(PP_DirectoryEntry* entry, 63 int32_t DirectoryReader::GetNextEntry(PP_DirectoryEntry* entry,
64 PP_CompletionCallback callback) { 64 PP_CompletionCallback callback) {
65 NOTIMPLEMENTED(); // TODO(darin): Implement me! 65 NOTIMPLEMENTED(); // TODO(darin): Implement me!
66 return PP_Error_Failed; 66 return PP_Error_Failed;
67 } 67 }
68 68
69 } // namespace pepper 69 } // namespace pepper
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698