Issue 2800026: Make import from the options menu OOP on Mac OS X....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2800026: Make import from the options menu OOP on Mac OS X.... (Closed)

Created:
10 years, 6 months ago by Miranda Callahan

Modified:
9 years, 7 months ago

Reviewers:
jeremy

CC:
chromium-reviews, kuchhal, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Make import from the options menu OOP on Mac OS X. BUG=46701 TEST=import Firefox passwords from the menu once the browser is running. Because import is OOP, FF passwords should be imported. All other import processes should still work as advertised. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50753

Patch Set 1 : '' #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	chrome/browser/cocoa/import_settings_dialog.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	chrome/browser/importer/importer.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages