Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(770)

Unified Diff: chrome/browser/cocoa/preferences_window_controller.mm

Issue 2799054: Remove the AutoFill enable/disable radio from the Options dialog to the AutoFill dialog (Closed)
Patch Set: Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/cocoa/preferences_window_controller.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/cocoa/preferences_window_controller.mm
diff --git a/chrome/browser/cocoa/preferences_window_controller.mm b/chrome/browser/cocoa/preferences_window_controller.mm
index 3bc8ef621a255cb4a4cbcbc3c5e3dbd538fe3ecd..e0a647045dd9ac5a97fd6d680d1b9c5a38c9d5f3 100644
--- a/chrome/browser/cocoa/preferences_window_controller.mm
+++ b/chrome/browser/cocoa/preferences_window_controller.mm
@@ -345,7 +345,6 @@ CGFloat AutoSizeUnderTheHoodContent(NSView* view,
- (void)setRestoreOnStartupIndex:(NSInteger)type;
- (void)setShowHomeButton:(BOOL)value;
- (void)setPasswordManagerEnabledIndex:(NSInteger)value;
-- (void)setFormAutofillEnabledIndex:(NSInteger)value;
- (void)setIsUsingDefaultTheme:(BOOL)value;
- (void)setShowAlternateErrorPages:(BOOL)value;
- (void)setUseSuggest:(BOOL)value;
@@ -789,7 +788,6 @@ class ManagedPrefsBannerState : public ManagedPrefsBannerBase {
// Personal Stuff panel
askSavePasswords_.Init(prefs::kPasswordManagerEnabled,
prefs_, observer_.get());
- formAutofill_.Init(prefs::kAutoFillEnabled, prefs_, observer_.get());
currentTheme_.Init(prefs::kCurrentThemeID, prefs_, observer_.get());
// Under the hood panel
@@ -1234,10 +1232,6 @@ const int kDisabledIndex = 1;
[self setPasswordManagerEnabledIndex:askSavePasswords_.GetValue() ?
kEnabledIndex : kDisabledIndex];
}
- if (*prefName == prefs::kAutoFillEnabled) {
- [self setFormAutofillEnabledIndex:formAutofill_.GetValue() ?
- kEnabledIndex : kDisabledIndex];
- }
if (*prefName == prefs::kCurrentThemeID) {
[self setIsUsingDefaultTheme:currentTheme_.GetValue().length() == 0];
}
@@ -1357,18 +1351,6 @@ const int kDisabledIndex = 1;
return askSavePasswords_.GetValue() ? kEnabledIndex : kDisabledIndex;
}
-- (void)setFormAutofillEnabledIndex:(NSInteger)value {
- if (value == kEnabledIndex)
- [self recordUserAction:UserMetricsAction("Options_FormAutofill_Enable")];
- else
- [self recordUserAction:UserMetricsAction("Options_FormAutofill_Disable")];
- formAutofill_.SetValue(value == kEnabledIndex ? true : false);
-}
-
-- (NSInteger)formAutofillEnabledIndex {
- return formAutofill_.GetValue() ? kEnabledIndex : kDisabledIndex;
-}
-
- (void)setIsUsingDefaultTheme:(BOOL)value {
if (value)
[self recordUserAction:UserMetricsAction(
« no previous file with comments | « chrome/browser/cocoa/preferences_window_controller.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698