Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2799047: Call rand_s() in a worker process before entering the sandbox. (Closed)

Created:
10 years, 5 months ago by Yuta Kitamura
Modified:
9 years, 7 months ago
Reviewers:
yutak, ukai, jam
CC:
chromium-reviews, jam, Paweł Hajdan Jr.
Visibility:
Public.

Description

Call rand_s() in a worker process before entering the sandbox. We need to do it to cause advapi32.dll to load the sandbox is turned on. Otherwise rand_s() will fail in the sandbox. BUG=47390 TEST=Run "ui_tests --gtest_filter=WorkerTest.WorkerWebSocketLayoutTests". Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53027

Patch Set 1 #

Patch Set 2 : Add test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/worker/worker_main.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/worker/worker_uitest.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Yuta Kitamura
Please see the following thread for the background of this patch: http://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thread/9ca0b94a3351cffb# Thanks,
10 years, 5 months ago (2010-06-30 06:21:05 UTC) #1
jam
the change is good, but why not add tests now?
10 years, 5 months ago (2010-07-01 06:57:26 UTC) #2
yutak_google.com
Because I thought I needed to add a layout test to WebKit. But I now ...
10 years, 5 months ago (2010-07-01 08:06:32 UTC) #3
Yuta Kitamura
Added a test. I'm waiting for my try job to complete, but there are so ...
10 years, 5 months ago (2010-07-20 02:32:51 UTC) #4
Yuta Kitamura
Try was successful. [ RUN ] WorkerTest.FLAKY_WorkerWebSocketLayoutTests WARNING:webkitpy.layout_tests.port.websocket_server:No handler_map_file found [ OK ] WorkerTest.FLAKY_WorkerWebSocketLayoutTests (13451 ...
10 years, 5 months ago (2010-07-20 08:58:28 UTC) #5
ukai
10 years, 5 months ago (2010-07-20 08:59:38 UTC) #6
LGTM

On 2010/07/20 08:58:28, Yuta Kitamura wrote:
> Try was successful.
> 
> [ RUN      ] WorkerTest.FLAKY_WorkerWebSocketLayoutTests
> WARNING:webkitpy.layout_tests.port.websocket_server:No handler_map_file found
> [       OK ] WorkerTest.FLAKY_WorkerWebSocketLayoutTests (13451 ms)

Powered by Google App Engine
This is Rietveld 408576698