Issue 2799042: Windows: Replace tabs in content settings with a listbox.

Issue 2799042: Windows: Replace tabs in content settings with a listbox. (Closed)

Created:
10 years, 5 months ago by Nico

Modified:
9 years, 7 months ago

Reviewers:
sky

CC:
chromium-reviews, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Windows: Replace tabs in content settings with a listbox. Depends on http://codereview.chromium.org/2815034 BUG=45546 TEST=Open content settings dialog. Should have a list on the left instead of tabs on top. Other than that, the dialog should work as before. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51205

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 4

Patch Set 3 : '' #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+103 lines, -62 lines)			Patch
M	chrome/browser/views/options/content_filter_page_view.cc	View	2	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/views/options/content_settings_window_view.h	View	1 2	4 chunks	+25 lines, -7 lines	0 comments	Download
M	chrome/browser/views/options/content_settings_window_view.cc	View	1 2	6 chunks	+74 lines, -50 lines	0 comments	Download
M	views/controls/label.h	View	2	4 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Nico

Who are other people I can send windows/views related CLs to?

10 years, 5 months ago (2010-06-29 23:20:53 UTC) #1

sky

Assuming control-click doesn't clear the list selection, LGTM. http://codereview.chromium.org/2799042/diff/4/4002 File chrome/browser/views/options/content_settings_window_view.cc (right): http://codereview.chromium.org/2799042/diff/4/4002#newcode115 chrome/browser/views/options/content_settings_window_view.cc:115: ShowSettingsPage(listbox_->SelectedRow()); ...

10 years, 5 months ago (2010-06-30 00:01:11 UTC) #2

Nico

10 years, 5 months ago (2010-06-30 00:15:54 UTC) #3

Thanks.

http://codereview.chromium.org/2799042/diff/4/4002
File chrome/browser/views/options/content_settings_window_view.cc (right):

http://codereview.chromium.org/2799042/diff/4/4002#newcode115
chrome/browser/views/options/content_settings_window_view.cc:115:
ShowSettingsPage(listbox_->SelectedRow());
On 2010/06/30 00:01:11, sky wrote:
> Can the user control-click to clear the selection of a listbox?

I tried control-clicking the currently selected row, another row, and the empty
white space in the list box. Nothing cleared the selection.

http://codereview.chromium.org/2799042/diff/4/4003
File chrome/browser/views/options/content_settings_window_view.h (right):

http://codereview.chromium.org/2799042/diff/4/4003#newcode83
chrome/browser/views/options/content_settings_window_view.h:83: //
|pages_[current_page_]| is the currently displayed page.
On 2010/06/30 00:01:11, sky wrote:
> Can you mention only one is parented.

Done.

Expand Messages | Collapse Messages