Added an about:about page (continuation)...

Added an about:about page (continuation)

continued from http://codereview.chromium.org/2754002/show
changelist disappeared after machine swap.

Added a new page, about:about (or chrome://about/about)
Includes a list of most of the about:* pages (eg. Left out about:inducebrowsercrashforrealz)

Page is constructed within browser_about_handler.cc

BUG=44699
TEST=Go to about:about, and see if About page loads. Check if links work. 


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50917

[Ryan Tseng, 2010-06-25 23:21:19]

Made changes, please review

Thanks
Ryan

[Peter Kasting, 2010-06-25 23:29:12]

LGTM

http://codereview.chromium.org/2799038/diff/1/2
File chrome/browser/browser_about_handler.cc (right):

http://codereview.chromium.org/2799038/diff/1/2#newcode241
chrome/browser/browser_about_handler.cc:241: html.append("<h2>List of About
Pages</h2><ul>\n");
Nit: Pages -> pages?

http://codereview.chromium.org/2799038/diff/1/2#newcode255
chrome/browser/browser_about_handler.cc:255: html.append("needs to be typed into
omnibar </h2><ul>");
Nit: How about:

html.append("</ul><h2>The following pages are for debugging purposes only.  "
            "Because they crash or hang the renderer, they're not linked "
            "directly; you can type them into the address bar if you need "
            "them.</h2><ul>");

[Lei Zhang, 2010-06-26 02:05:55]

Reverting, compile fails on ChromeOS.

chrome/browser/browser_about_handler.cc:135: error: 'kOSCreditPath' was not
declared in this scope