Issue 2799029: Mark SrpcPluginTest as flaky.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2799029: Mark SrpcPluginTest as flaky. (Closed)

Created:
10 years, 6 months ago by ericu

Modified:
9 years, 7 months ago

Reviewers:
neb, Paweł Hajdan Jr.

CC:
chromium-reviews, native-client-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Mark SrpcPluginTest as flaky. BUG=643 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50665

Patch Set 1 #

Total comments: 1

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/test/nacl/nacl_test.cc	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Paweł Hajdan Jr.

Drive-by. Could you do a follow-up CL? http://codereview.chromium.org/2799029/diff/1/2 File chrome/test/nacl/nacl_test.cc (right): http://codereview.chromium.org/2799029/diff/1/2#newcode146 chrome/test/nacl/nacl_test.cc:146: TEST_F(NaClTest, FLAKY_SrpcPluginTest) ...

10 years, 6 months ago (2010-06-24 06:24:04 UTC) #2

ericu

10 years, 6 months ago (2010-06-24 18:16:13 UTC) #3

Done.  http://codereview.chromium.org/2871024/show

On Wed, Jun 23, 2010 at 11:24 PM,  <phajdan.jr@chromium.org> wrote:
> Drive-by. Could you do a follow-up CL?
>
>
> http://codereview.chromium.org/2799029/diff/1/2
> File chrome/test/nacl/nacl_test.cc (right):
>
> http://codereview.chromium.org/2799029/diff/1/2#newcode146
> chrome/test/nacl/nacl_test.cc:146: TEST_F(NaClTest,
> FLAKY_SrpcPluginTest) {
> Please make sure a bug is filed with failure logs pasted inline, and put
> a "Flaky, http://crbug.com/1234." comment above the test.
>
> http://codereview.chromium.org/2799029/show
>

Expand Messages | Collapse Messages