Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2799015: When deleting bookmark buttons, make sure all delayed messages... (Closed)

Created:
10 years, 6 months ago by John Grabowski
Modified:
9 years, 6 months ago
Reviewers:
Bons, dhollowa
CC:
chromium-reviews, John Grabowski, ben+cc_chromium.org, pam+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

When deleting bookmark buttons, make sure all delayed messages (e.g. for hover-open) are cancelled. TEST=Add 100 bookmarks to the bar. Open overflow menu. Use context menu to delete them. Repeat 100 times. Make sure no crashing. BUG=http://crbug.com/46175 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50201

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -0 lines) Patch
M chrome/browser/cocoa/bookmark_bar_controller_unittest.mm View 2 chunks +51 lines, -0 lines 5 comments Download
M chrome/browser/cocoa/bookmark_bar_folder_controller.mm View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
John Grabowski
10 years, 6 months ago (2010-06-18 00:04:04 UTC) #1
dhollowa
LGTM.
10 years, 6 months ago (2010-06-18 00:14:52 UTC) #2
Bons
LGTM http://codereview.chromium.org/2799015/diff/4001/5001 File chrome/browser/cocoa/bookmark_bar_controller_unittest.mm (right): http://codereview.chromium.org/2799015/diff/4001/5001#newcode1 chrome/browser/cocoa/bookmark_bar_controller_unittest.mm:1: // Copyright (c) 2009 The Chromium Authors. All ...
10 years, 6 months ago (2010-06-18 01:32:55 UTC) #3
John Grabowski
10 years, 6 months ago (2010-06-18 01:54:46 UTC) #4
http://codereview.chromium.org/2799015/diff/4001/5001
File chrome/browser/cocoa/bookmark_bar_controller_unittest.mm (right):

http://codereview.chromium.org/2799015/diff/4001/5001#newcode1
chrome/browser/cocoa/bookmark_bar_controller_unittest.mm:1: // Copyright (c)
2009 The Chromium Authors. All rights reserved.
On 2010/06/18 01:32:55, Andrew Bonventre (Bons) wrote:
> 2010

Not sure what our convention is, but I generally ignore lice.

http://codereview.chromium.org/2799015/diff/4001/5001#newcode598
chrome/browser/cocoa/bookmark_bar_controller_unittest.mm:598: for (int i = 0; i
< 100; i++) {
On 2010/06/18 01:32:55, Andrew Bonventre (Bons) wrote:
> ++i (C++ style guide nagging in my BRAIN)

From the style guide, "For simple scalar (non-object) values there is no reason
to prefer one form and we allow either. For iterators and other template types,
use pre-increment."

Powered by Google App Engine
This is Rietveld 408576698