Update installer for internal plugin.

Update installer for internal plugin.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49757

[viettrungluu, 2010-06-15 01:45:43]

You may want to ping mmoss (or maybe thestig?) for the Linux bits and cpu for
the Windows ones....

http://codereview.chromium.org/2799006/diff/2001/3001
File chrome/chrome_dll.gypi (right):

http://codereview.chromium.org/2799006/diff/2001/3001#newcode292
chrome/chrome_dll.gypi:292: ['internal_pdf', {
When/where/how is internal_pdf set?

http://codereview.chromium.org/2799006/diff/2001/3004
File chrome/installer/mini_installer/chrome.release (right):

http://codereview.chromium.org/2799006/diff/2001/3004#newcode59
chrome/installer/mini_installer/chrome.release:59: pdf.dll: %(VersionDir)s\
If this is only available for official/branded builds, I think it should go in
the section below? (I don't know for sure. I think Carlos would know.)

http://codereview.chromium.org/2799006/diff/2001/3005
File chrome/installer/mini_installer/chrome_frame.release (right):

http://codereview.chromium.org/2799006/diff/2001/3005#newcode47
chrome/installer/mini_installer/chrome_frame.release:47: pdf.dll:
%(VersionDir)s\
Ditto.

http://codereview.chromium.org/2799006/diff/2001/3007
File chrome/tools/build/linux/FILES.cfg (right):

http://codereview.chromium.org/2799006/diff/2001/3007#newcode94
chrome/tools/build/linux/FILES.cfg:94: # PDF Plugin files:
Now that I think of it, I'm also worried about the official versus non-official
build thing (but then I don't know why the Flash files are in win/FILES).

http://codereview.chromium.org/2799006/diff/2001/3009
File chrome/tools/build/win/FILES.cfg (right):

http://codereview.chromium.org/2799006/diff/2001/3009#newcode343
chrome/tools/build/win/FILES.cfg:343: 'buildtype': ['dev', 'official'],
It's not entirely clear to me what "dev" builds are.... (Continuous Chromium
builds? Nightly Chrome builds?)

[jam, 2010-06-15 01:52:07]

http://codereview.chromium.org/2799006/diff/2001/3001
File chrome/chrome_dll.gypi (right):

http://codereview.chromium.org/2799006/diff/2001/3001#newcode292
chrome/chrome_dll.gypi:292: ['internal_pdf', {
On 2010/06/15 01:45:43, viettrungluu wrote:
> When/where/how is internal_pdf set?

It's mapped in using supplemental gypi stuff, when the internal code is fetched
using .gclient.  i.e. magic that bradnelson setup for us.

http://codereview.chromium.org/2799006/diff/2001/3004
File chrome/installer/mini_installer/chrome.release (right):

http://codereview.chromium.org/2799006/diff/2001/3004#newcode59
chrome/installer/mini_installer/chrome.release:59: pdf.dll: %(VersionDir)s\
On 2010/06/15 01:45:43, viettrungluu wrote:
> If this is only available for official/branded builds, I think it should go in
> the section below? (I don't know for sure. I think Carlos would know.)

it'll be available for both (the case below was different for other reasons, we
can talk about it offline)

http://codereview.chromium.org/2799006/diff/2001/3007
File chrome/tools/build/linux/FILES.cfg (right):

http://codereview.chromium.org/2799006/diff/2001/3007#newcode94
chrome/tools/build/linux/FILES.cfg:94: # PDF Plugin files:
On 2010/06/15 01:45:43, viettrungluu wrote:
> Now that I think of it, I'm also worried about the official versus
non-official
> build thing (but then I don't know why the Flash files are in win/FILES).

think of this binary as more like any chrome binary that we can distribute
however we want, except that the code isn't open.

http://codereview.chromium.org/2799006/diff/2001/3009
File chrome/tools/build/win/FILES.cfg (right):

http://codereview.chromium.org/2799006/diff/2001/3009#newcode343
chrome/tools/build/win/FILES.cfg:343: 'buildtype': ['dev', 'official'],
On 2010/06/15 01:45:43, viettrungluu wrote:
> It's not entirely clear to me what "dev" builds are.... (Continuous Chromium
> builds? Nightly Chrome builds?)

i'm not sure either, i'm treating it like any of the other chrome binaries for
now though.