Notification balloons don't want the WS_EX_LAYOUTRTL style flag, since the di...

views/widget/widget.h

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef VIEWS_WIDGET_WIDGET_H_
 #define VIEWS_WIDGET_WIDGET_H_
 
 #include <vector>
 
 #include "gfx/native_widget_types.h"
@@ skipping 46 matching lines @@
   enum EventsParam {
     AcceptEvents,
     NotAcceptEvents
   };
 
   enum DeleteParam {
     DeleteOnDestroy,
     NotDeleteOnDestroy
   };
 
+  enum MirroringParam {
+    MirrorOriginInRTL,
+    DontMirrorOriginInRTL
+  };
+
   // Creates a transient popup widget specific to the current platform.
+  // If |mirror_in_rtl| is set to MirrorOriginInRTL, the contents of the
+  // popup will be mirrored if the current locale is RTL.  You should use

[jeremy, 2010/06/10 20:58:58]

"the contents of the popup will be mirrored" -> The view origin will be
mirrored.

+  // DontMirrorOriginInRTL if you are aleady handling the RTL layout within
+  // the widget.
   static Widget* CreatePopupWidget(TransparencyParam transparent,
                                    EventsParam accept_events,
-                                   DeleteParam delete_on_destroy);
+                                   DeleteParam delete_on_destroy,
+                                   MirroringParam mirror_in_rtl);

[idana, 2010/06/16 13:46:16]

Since almost all the call sites use MirrorOriginInRTL (the default behavior), it
makes more sense to overload CreatePopupWidget such that only BalloonView uses
the version which takes the mirroring config.

 
   // Returns the root view for |native_window|. If |native_window| does not have
   // a rootview, this recurses through all of |native_window|'s children until
   // one is found. If a root view isn't found, null is returned.
   static RootView* FindRootView(gfx::NativeWindow native_window);
 
   // Returns list of all root views for the native window and its
   // children.
   static void FindAllRootViews(gfx::NativeWindow native_window,
                                std::vector<RootView*>* root_views);
@@ skipping 126 matching lines @@
                                     View *child) = 0;
 
   // Returns true if the native view |native_view| is contained in the
   // views::View hierarchy rooted at this widget.
   virtual bool ContainsNativeView(gfx::NativeView native_view) = 0;
 };
 
 }  // namespace views
 
 #endif // VIEWS_WIDGET_WIDGET_H_