Add the repo tool which is going to be used for iterative tasks across multiple git repos

Add the repo tool which is going to be used for iterative tasks across multiple git repos

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52240

[M-A Ruel, 2010-06-11 14:33:47]

Can you explain a bit more?

[anush, 2010-06-11 14:49:46]

Maruel,
   Yes. We are planning on using "repo" documented here
http://source.android.com/source/git-repo.html for working across
multiple git repos at the same time. A typical workflow is documented
here
http://sites.google.com/a/chromium.org/dev/chromium-os/how-tos-and-troublesho...
. For now it is an alternate workflow(in testing) instead of using
gclient to sync sources but once we have all our build enhancements
rolled out (documented here
https://docs.google.com/a/google.com/Doc?docid=0AdXn1_Fb89qSZGZyMzk3NTJfODNnc...)
ChromeOS developers can sync only the projects they are working on
instead of all the sources from ~92 repos.

The reason I would like to add it to depot_tools is that it is
automatically available to all developers and they dont have to setup
repo manually.

Thanks
Anush

On Fri, Jun 11, 2010 at 7:33 AM,  <maruel@chromium.org> wrote:
> Can you explain a bit more?
>
> http://codereview.chromium.org/2792012/show
>

[M-A Ruel, 2010-06-11 15:11:50]

On 2010/06/11 14:49:46, anush wrote:
> Maruel,
>    Yes. We are planning on using "repo" documented here
> http://source.android.com/source/git-repo.html for working across
> multiple git repos at the same time. A typical workflow is documented
> here
>
http://sites.google.com/a/chromium.org/dev/chromium-os/how-tos-and-troublesho...
> . For now it is an alternate workflow(in testing) instead of using
> gclient to sync sources but once we have all our build enhancements
> rolled out (documented here
>
https://docs.google.com/a/google.com/Doc?docid=0AdXn1_Fb89qSZGZyMzk3NTJfODNnc...)
> ChromeOS developers can sync only the projects they are working on
> instead of all the sources from ~92 repos.

Please see the comments I added in the document. This was never needed (!)

> The reason I would like to add it to depot_tools is that it is
> automatically available to all developers and they dont have to setup
> repo manually.

I'm fine with including the tool but keep in mind that means you're on your own
w.r.t. finishing the try server work.

Also, I'm not sure it's a good idea to checkin the tool since it's explicitely
made to be easy to self-install; e.g.
curl http://android.git.kernel.org/repo > ~/bin/repo

Otherwise if repo self-updates, it will be overridden by the version checked in
in depot_tools (?)

[anush, 2010-06-11 15:44:36]

On Fri, Jun 11, 2010 at 8:11 AM,  <maruel@chromium.org> wrote:
> On 2010/06/11 14:49:46, anush wrote:
>>
>> Maruel,
>>    Yes. We are planning on using "repo" documented here
>> http://source.android.com/source/git-repo.html for working across
>> multiple git repos at the same time. A typical workflow is documented
>> here
>
>
http://sites.google.com/a/chromium.org/dev/chromium-os/how-tos-and-troublesho...
>>
>> . For now it is an alternate workflow(in testing) instead of using
>> gclient to sync sources but once we have all our build enhancements
>> rolled out (documented here
>
>
https://docs.google.com/a/google.com/Doc?docid=0AdXn1_Fb89qSZGZyMzk3NTJfODNnc...)
>>
>> ChromeOS developers can sync only the projects they are working on
>> instead of all the sources from ~92 repos.
>
> Please see the comments I added in the document. This was never needed (!)
>
>> The reason I would like to add it to depot_tools is that it is
>> automatically available to all developers and they dont have to setup
>> repo manually.
>
> I'm fine with including the tool but keep in mind that means you're on your
> own
> w.r.t. finishing the try server work.

We only change the checkout of code mechanism everything else remains
the same. Im not familiar with the try-bot arch but would it be hard
to substitute only the "checkout the sources" part? We still have the
exact same git cl * commands.

>
> Also, I'm not sure it's a good idea to checkin the tool since it's
> explicitely
> made to be easy to self-install; e.g.
> curl http://android.git.kernel.org/repo > ~/bin/repo
>

Yes that is going to be the recommended way but we thought having it
in the path automatically will be one less step since we need git cl
commands etc.

> Otherwise if repo self-updates, it will be overridden by the version checked
> in
> in depot_tools (?)

actually that is only a small frontend script (which hasn't changed in
~2yrs) everytime repo updates itself inside the .repo dir of the
source checkout directory.

Can you LGTM if it is ok with you?

Thanks
Anush

>
> http://codereview.chromium.org/2792012/show
>

[M-A Ruel, 2010-06-11 16:33:23]

On 2010/06/11 15:44:36, anush wrote:
> On Fri, Jun 11, 2010 at 8:11 AM,  <mailto:maruel@chromium.org> wrote:
> >> ChromeOS developers can sync only the projects they are working on
> >> instead of all the sources from ~92 repos.
> >
> > Please see the comments I added in the document. This was never needed (!)

???

> We only change the checkout of code mechanism everything else remains
> the same. Im not familiar with the try-bot arch but would it be hard
> to substitute only the "checkout the sources" part? We still have the
> exact same git cl * commands.

Does repo has a "revert to clean state" command? I'm not familiar with it. I
guess it has something similar, if so, it's doable but I won't take
responsibility to bring this up.


You still haven't addressed two of my comments I added in the doc:

1) Ok, does that mean ripping out git support in gclient? BTW, gclient has the
From() keyword you could have used to propagate the dependencies more cleanly

2) Pinned DEPS are the 'normal' way to checkout a specified revision. I've just
seen activity on http://crosbug.com/2890 with some hack to enforce it instead of
doing it natively.

[M-A Ruel, 2010-06-11 17:15:54]

btw, you can check-in (I don't mind) but please answer the questions.

[anush, 2010-06-11 18:13:00]

On Fri, Jun 11, 2010 at 9:33 AM,  <maruel@chromium.org> wrote:
> On 2010/06/11 15:44:36, anush wrote:
>>
>> On Fri, Jun 11, 2010 at 8:11 AM,  <mailto:maruel@chromium.org> wrote:
>> >> ChromeOS developers can sync only the projects they are working on
>> >> instead of all the sources from ~92 repos.
>> >
>> > Please see the comments I added in the document. This was never needed
>> > (!)
>
> ???

Yes. We have that as a stop gap measure to give something to vendors
until we got a fully reproducible build system using the new tools.

>
>> We only change the checkout of code mechanism everything else remains
>> the same. Im not familiar with the try-bot arch but would it be hard
>> to substitute only the "checkout the sources" part? We still have the
>> exact same git cl * commands.
>
> Does repo has a "revert to clean state" command? I'm not familiar with it. I
> guess it has something similar, if so, it's doable but I won't take
> responsibility to bring this up.

Sure, I can help with this (I am on vacation for 3 weeks, but when I get back).

>
>
> You still haven't addressed two of my comments I added in the doc:
>
> 1) Ok, does that mean ripping out git support in gclient? BTW, gclient has
> the
> From() keyword you could have used to propagate the dependencies more
> cleanly
>

No, I dont think we need to rip it out. We will have a transition
phase when both will be available.

> 2) Pinned DEPS are the 'normal' way to checkout a specified revision. I've
> just
> seen activity on http://crosbug.com/2890 with some hack to enforce it
> instead of
> doing it natively.
>

Im not sure I understand what is doing natively, but basically in the
new model we will not be rely on the global deps and instead the
ebuilds themselves will point to their corresponding git rev.

> http://codereview.chromium.org/2792012/show
>

Thanks for the LGTM on the other email. I will push it up.

[M-A Ruel, 2010-06-11 18:41:50]

On 2010/06/11 18:13:00, anush wrote:
> > Does repo has a "revert to clean state" command? I'm not familiar with it. I
> > guess it has something similar, if so, it's doable but I won't take
> > responsibility to bring this up.
> 
> Sure, I can help with this (I am on vacation for 3 weeks, but when I get
back).

Let me be clearify with s/can help with/will do/. If you change the workflow,
this implies you are taking full responsibility of this change.

M-A

[anush, 2010-06-11 21:54:21]

On Fri, Jun 11, 2010 at 11:41 AM,  <maruel@chromium.org> wrote:
> On 2010/06/11 18:13:00, anush wrote:
>>
>> > Does repo has a "revert to clean state" command? I'm not familiar with
>> > it. I
>> > guess it has something similar, if so, it's doable but I won't take
>> > responsibility to bring this up.
>
>> Sure, I can help with this (I am on vacation for 3 weeks, but when I get
>
> back).
>
> Let me be clearify with s/can help with/will do/. If you change the
> workflow,
> this implies you are taking full responsibility of this change.
>

Yup. Chris Sosa will be working on it along with the "Preflight
buildbot". CC'ing him

Anush

> M-A
>
> http://codereview.chromium.org/2792012/show
>