Issue 279007: Rolling webkit r:49583

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 279007: Rolling webkit r:49583 (Closed)

Created:
11 years, 2 months ago by yaar

Modified:
9 years, 7 months ago

Reviewers:
dglazkov

CC:
chromium-reviews_googlegroups.com, jeremy

Visibility:
Public.

Description

Rolling webkit r:49583 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29057

Patch Set 1 #

Total comments: 2

Patch Set 2 : Patch 2 #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -3 lines)			Patch
	M	DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	webkit/tools/layout_tests/test_expectations.txt	View	1	2 chunks	+15 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

yaar

Dimitri, I'll land this as BUG_YAAR and then file bugs. Let me know if you ...

11 years, 2 months ago (2009-10-14 22:26:56 UTC) #1

dglazkov

11 years, 2 months ago (2009-10-14 22:29:50 UTC) #2

LGTM with nits:

http://codereview.chromium.org/279007/diff/1/3
File webkit/tools/layout_tests/test_expectations.txt (right):

http://codereview.chromium.org/279007/diff/1/3#newcode110
Line 110: //BUG24182 SLOW WIN : LayoutTests/css1/font_properties/font.html =
PASS
Did you mean to comment it out?

http://codereview.chromium.org/279007/diff/1/3#newcode3199
Line 3199: BUG_YAAR : LayoutTests/inspector/console-tests.html = TIMEOUT
You can just mark SKIP : LayoutTests/inspector = FAIL, and give the bug to
pfeldman, since he's the instigator of all this! :)

Expand Messages | Collapse Messages