Issue 279005: Disable "Reset to Default Theme" button in Google Chrome Options / Personal S...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 279005: Disable "Reset to Default Theme" button in Google Chrome Options / Personal S... (Closed)

Created:
11 years, 2 months ago by Miranda Callahan

Modified:
9 years, 7 months ago

Reviewers:
Avi (use Gerrit)

CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Disable "Reset to Default Theme" button in Google Chrome Options / Personal Stuff when the default theme is already set, Windows side. BUG= http://crbug.com/18585 TEST= Install a default theme, note that button is disabled. Install a non-default theme, note that button is enabled. NOTE: this will only respond to default themes set by the reset button itself right now, because the "default theme" in the gallery is not a "true" default. When this code goes out, then the gallery theme can be changed. See http://crbug.com/24857 . Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29050

Patch Set 1 #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -0 lines)			Patch
	M	chrome/browser/views/options/content_page_view.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	chrome/browser/views/options/content_page_view.cc	View		2 chunks	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Miranda Callahan

Hi, Avi -- this patch is so similar to the Mac side that you just ...

11 years, 2 months ago (2009-10-14 21:47:58 UTC) #1

Avi (use Gerrit)

11 years, 2 months ago (2009-10-14 21:50:18 UTC) #2

Looks entirely feasible. If it actually works, LGTM.

Expand Messages | Collapse Messages