Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 279002: The send done event in the old send watcher can be NULL as it can be signaled... (Closed)

Created:
11 years, 2 months ago by ananta
Modified:
9 years, 6 months ago
Reviewers:
jam
CC:
chromium-reviews_googlegroups.com, jam
Visibility:
Public.

Description

The send done event in the old send watcher can be NULL as it can be signaled in a nested sync channel send scenario which yields control to the plugin before the quit task is processed. This is perfectly legit and we should not attempt to StopWatching the send done watcher as it crashes. I will work on a unit test for this in a subsequent CL. TBR=jam Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29000

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ipc/ipc_sync_channel.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
ananta
11 years, 2 months ago (2009-10-14 19:57:28 UTC) #1
jam
11 years, 2 months ago (2009-10-14 20:04:02 UTC) #2
I don't understand what the problem is?  The cl description mentions
StopWatching but the code is changing when StartWatching is called?

Powered by Google App Engine
This is Rietveld 408576698