Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(582)

Issue 2789003: Add unpatched bsdiff 4.3 to chrome/installer/mac/third_party/bsdiff (Closed)

Created:
10 years, 6 months ago by Mark Mentovai
Modified:
9 years, 7 months ago
Reviewers:
TVL
CC:
chromium-reviews, kuchhal
Visibility:
Public.

Description

Add unpatched bsdiff 4.3 to chrome/installer/mac/third_party/bsdiff I have non-algorithmic changes to bsdiff and bspatch, and they'll be easier to review and easier to identify in the future if an unpatched copy is checked in first. The bsdiff and bspatch that you'll find elsewhere in the repository are actually different forks of bsdiff, and aren't quite as appropriate for use in the Mac binary patcher. The other copies are Mozilla's variant of bsdiff. BUG=45017 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49280

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+780 lines, -0 lines) Patch
A chrome/installer/mac/third_party/bsdiff/LICENSE View 1 chunk +23 lines, -0 lines 0 comments Download
A chrome/installer/mac/third_party/bsdiff/Makefile View 1 chunk +15 lines, -0 lines 0 comments Download
A chrome/installer/mac/third_party/bsdiff/README.chromium View 1 chunk +12 lines, -0 lines 1 comment Download
A chrome/installer/mac/third_party/bsdiff/bsdiff.1 View 1 chunk +63 lines, -0 lines 0 comments Download
A chrome/installer/mac/third_party/bsdiff/bsdiff.c View 1 chunk +404 lines, -0 lines 0 comments Download
A chrome/installer/mac/third_party/bsdiff/bspatch.1 View 1 chunk +59 lines, -0 lines 0 comments Download
A chrome/installer/mac/third_party/bsdiff/bspatch.c View 1 chunk +204 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mark Mentovai
10 years, 6 months ago (2010-06-09 16:39:40 UTC) #1
TVL
10 years, 6 months ago (2010-06-09 16:58:58 UTC) #2
lg

http://codereview.chromium.org/2789003/diff/1/4
File chrome/installer/mac/third_party/bsdiff/README.chromium (right):

http://codereview.chromium.org/2789003/diff/1/4#newcode9
chrome/installer/mac/third_party/bsdiff/README.chromium:9: Binary diff/patch
utility
is it worth a comment here about why we have a copy here if it is also in other
places in the chromium tree?

Powered by Google App Engine
This is Rietveld 408576698