Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2788003: Enable chromoting in the build by default (Closed)

Created:
10 years, 6 months ago by Alpha Left Google
Modified:
9 years, 6 months ago
Reviewers:
laforge
CC:
chromium-reviews
Visibility:
Public.

Description

Enable chromoting in the build by default Set chromoting to be built by default. Also defines a ENABLE_CHROMOTING flag if chromoting is enabled in the build system so we can exclude chromoting if we don't want chromoting code to be linked in. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49482

Patch Set 1 #

Patch Set 2 : fix mac build #

Patch Set 3 : fixed mac #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -8 lines) Patch
M build/common.gypi View 1 2 2 chunks +5 lines, -2 lines 0 comments Download
M remoting/chromoting.gyp View 1 chunk +2 lines, -1 line 0 comments Download
M remoting/client/x11_client.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M remoting/client/x11_view.h View 3 chunks +4 lines, -3 lines 0 comments Download
M remoting/client/x11_view.cc View 2 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
laforge
10 years, 6 months ago (2010-06-10 02:16:54 UTC) #1
LGTM

Powered by Google App Engine
This is Rietveld 408576698