Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2788001: Remove all grab widget in screen locker. (Closed)

Created:
10 years, 6 months ago by oshima
Modified:
9 years, 6 months ago
Reviewers:
whywhat, sky
CC:
chromium-reviews, nkostylev+cc_chromium.org, davemoore+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Remove all grab widget in screen locker so that gtk simply propagate events, instead of adding window_contents_ as grab widget. Explicitly adding grab widget was confusing gtk and the event has been handled by grab widget rather than by the window the event is forwarded to. This CL fixes it by removing all grab widget and let gtk propagage event in target window. BUG=none TEST=open screen locker, type wrong password to show message bubble, then close it by clicking close (x) button. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49314

Patch Set 1 : " #

Patch Set 2 : comment update #

Total comments: 3

Patch Set 3 : fix comment and removed dlog #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M chrome/browser/chromeos/login/screen_locker.cc View 1 2 3 chunks +9 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
oshima
10 years, 6 months ago (2010-06-09 18:04:37 UTC) #1
oshima
10 years, 6 months ago (2010-06-09 18:17:21 UTC) #2
sky
10 years, 6 months ago (2010-06-09 18:54:26 UTC) #3
LGTM

http://codereview.chromium.org/2788001/diff/11001/12001
File chrome/browser/chromeos/login/screen_locker.cc (right):

http://codereview.chromium.org/2788001/diff/11001/12001#newcode91
chrome/browser/chromeos/login/screen_locker.cc:91: // Make sure there is no grab
widget so that gtk simply propagages
propagages -> propagates

http://codereview.chromium.org/2788001/diff/11001/12001#newcode92
chrome/browser/chromeos/login/screen_locker.cc:92: // an event.  This is
necessary to allow messag bubble and password
message

http://codereview.chromium.org/2788001/diff/11001/12001#newcode195
chrome/browser/chromeos/login/screen_locker.cc:195: // DLOG(INFO) << "ignore
event src non grab window: " << event->type;
Just nuke the DLOG.

Powered by Google App Engine
This is Rietveld 408576698