Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Unified Diff: gclient.py

Issue 2786013: Incremental changes towards more efficient refactoring of gclient.py (Closed)
Patch Set: Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | gclient_scm.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gclient.py
diff --git a/gclient.py b/gclient.py
index 586c655f912aef538963c18e246e0a7a6a2f7375..058865db9ecd7efd026c3362ac1f1ed01e04bbdc 100644
--- a/gclient.py
+++ b/gclient.py
@@ -157,6 +157,7 @@ class GClientKeywords(object):
class GClient(GClientKeywords):
"""Object that represent a gclient checkout."""
+ DEPS_FILE = 'DEPS'
SUPPORTED_COMMANDS = [
'cleanup', 'diff', 'export', 'pack', 'revert', 'status', 'update',
@@ -174,8 +175,6 @@ class GClient(GClientKeywords):
"linux2": "unix",
}
- DEPS_FILE = 'DEPS'
-
DEFAULT_CLIENT_FILE_TEXT = ("""\
solutions = [
{ "name" : "%(solution_name)s",
@@ -1040,14 +1039,22 @@ def CMDrunhooks(parser, args):
def CMDrevinfo(parser, args):
- """Outputs details for every dependencies."""
- parser.add_option("--deps", dest="deps_os", metavar="OS_LIST",
- help="override deps for the specified (comma-separated) "
- "platform(s); 'all' will process all deps_os "
- "references")
- parser.add_option("-s", "--snapshot", action="store_true",
- help="create a snapshot file of the current "
- "version of all repositories")
+ """Output revision info mapping for the client and its dependencies.
+
+ This allows the capture of an overall "revision" for the source tree that
+ can be used to reproduce the same tree in the future. It is only useful for
+ "unpinned dependencies", i.e. DEPS/deps references without a svn revision
+ number or a git hash. A git branch name isn't "pinned" since the actual
+ commit can change.
+ """
+ parser.add_option('--deps', dest='deps_os', metavar='OS_LIST',
+ help='override deps for the specified (comma-separated) '
+ 'platform(s); \'all\' will process all deps_os '
+ 'references')
+ parser.add_option('-s', '--snapshot', action='store_true',
+ help='creates a snapshot .gclient file of the current '
+ 'version of all repositories to reproduce the tree, '
+ 'implies -a')
(options, args) = parser.parse_args(args)
client = GClient.LoadCurrentConfig(options)
if not client:
« no previous file with comments | « no previous file | gclient_scm.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698