Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 2786012: Merge 49131 - Add rgb_frame size tracking and resizing to fix security issue ... (Closed)

Created:
10 years, 6 months ago by inferno
Modified:
9 years, 7 months ago
CC:
chromium-reviews, jam+cc_chromium.org, fbarchard, Alpha Left Google, ben+cc_chromium.org, darin-cc_chromium.org, awong, brettw-cc_chromium.org, scherkus (not reviewing)
Visibility:
Public.

Description

Merge 49131 - Add rgb_frame size tracking and resizing to fix security issue with changing sizes. Added negative checks on signed heights and widths, added negative check for signed heights and widths in backing store for video layering. Patch by cdn@chromium.org: http://codereview.chromium.org/2449006/show BUG=45267 TEST=Run on linux with --enable-video-layering and use <video> tag TBR=scherkus@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49559

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -17 lines) Patch
M chrome/browser/renderer_host/backing_store_x.cc View 4 chunks +21 lines, -5 lines 0 comments Download
M chrome/browser/renderer_host/video_layer_x.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/video_layer_x.cc View 3 chunks +21 lines, -12 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
inferno
10 years, 6 months ago (2010-06-11 18:36:01 UTC) #1
scherkus (not reviewing)
10 years, 6 months ago (2010-06-11 19:09:06 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698