Added checks to GetBufferedTime() to cap at the media's duration

Added checks to GetBufferedTime() to cap at the media's duration

No longer tries to estimate buffered time when media is fully loaded.
Also caps estimation at the duration of the media.

BUG=none
TEST=media_unittests

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49714

[vrk (LEFT CHROMIUM), 2010-06-10 01:30:06]

Hi Alpha, I changed the type of max_buffered_time_ as you suggested. Thanks!

On 2010/06/10 00:21:10, Victoria Kirst wrote:
>

[scherkus (not reviewing), 2010-06-10 02:50:23]

Don't forget BUG= and TEST= in CL description (you can use "none" if there is no
bug/test procedure).

Is it possible to get a unit test written?

it might be too hairy in which case dont bother :)

[vrk (LEFT CHROMIUM), 2010-06-14 17:14:43]

Added a unit test and made some other minor tweaks to the code. Please take a
look again when you have time, thank you! :)

Victoria

On 2010/06/10 02:50:23, scherkus wrote:
> Don't forget BUG= and TEST= in CL description (you can use "none" if there is
no
> bug/test procedure).
> 
> Is it possible to get a unit test written?
> 
> it might be too hairy in which case dont bother :)

[Alpha Left Google, 2010-06-14 18:29:16]

Please fix two nits. Then LGTM.

http://codereview.chromium.org/2782004/diff/16001/17001
File media/base/pipeline_impl.cc (right):

http://codereview.chromium.org/2782004/diff/16001/17001#newcode226
media/base/pipeline_impl.cc:226: DCHECK(buffered_bytes_ >= current_bytes_);
Should use DCHECK_GE(buffered_bytes, current_bytes);

Also move this line to where the two variables are used, which is the
calculation block below.

http://codereview.chromium.org/2782004/diff/16001/17002
File media/base/pipeline_impl.h (right):

http://codereview.chromium.org/2782004/diff/16001/17002#newcode415
media/base/pipeline_impl.h:415: friend class
PipelineImplTest_GetBufferedTime_Test;
include testing/gtest/include/gtest/gtest_prod.h
and use FRIEND_TEST instead, it's a marco that does the same thing as what you
have above.

[vrk (LEFT CHROMIUM), 2010-06-14 19:23:37]

Fixed the nits and will commit. Thanks Alpha!

http://codereview.chromium.org/2782004/diff/16001/17001
File media/base/pipeline_impl.cc (right):

http://codereview.chromium.org/2782004/diff/16001/17001#newcode226
media/base/pipeline_impl.cc:226: DCHECK(buffered_bytes_ >= current_bytes_);
On 2010/06/14 18:29:16, Alpha wrote:
> Should use DCHECK_GE(buffered_bytes, current_bytes);
> 
> Also move this line to where the two variables are used, which is the
> calculation block below.

Done.

http://codereview.chromium.org/2782004/diff/16001/17002
File media/base/pipeline_impl.h (right):

http://codereview.chromium.org/2782004/diff/16001/17002#newcode415
media/base/pipeline_impl.h:415: friend class
PipelineImplTest_GetBufferedTime_Test;
On 2010/06/14 18:29:16, Alpha wrote:
> include testing/gtest/include/gtest/gtest_prod.h
> and use FRIEND_TEST instead, it's a marco that does the same thing as what you
> have above.

Done.