Disable "Reset to Default Theme" button in Google Chrome Options / Personal S...

Disable "Reset to Default Theme" button in Google Chrome Options / Personal Stuff when the default theme is already set.
This change is for the Mac OS; Windows change in a separate patch.

BUG= http://crbug.com/18585
TEST= Install a default theme, note that button is disabled. Install a non-default theme, note that button is enabled. Rinse, repeat. NOTE: this will only respond to default themes set by the reset button itself right now, because the "default theme" in the gallery is not a "true" default.  When this code goes out, then the gallery theme can be changed.  See http://crbug.com/24857 .


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29047

[Miranda Callahan, 2009-10-14 20:43:48]

Glen, in order to make this CL work, we need to make the default theme from the
gallery go through the same path as the theme you get by hitting "reset to
default theme" in the Personal Stuff panel.  I was able to do this by simply
removing the two "null" entries from the manifest and adding the test in
BrowserThemeProvider for the empty theme, but we'll have to do this in the
gallery as well.  I think it makes sense, as these entries are dummies in any
case, but wanted to run this by you in case something depends on the "null"
color and notused.png.

[TVL, 2009-10-14 21:22:03]

+ avi since he did the first them drawing/switch code
+ pink for the bindings plumbing in the prefs window

http://codereview.chromium.org/278004/diff/4001/9
File chrome/browser/cocoa/preferences_window_controller.mm (right):

http://codereview.chromium.org/278004/diff/4001/9#newcode775
Line 775: return [currTheme isKindOfClass:[NSString class]] && [currTheme
length] == 0;
why do these checks with NSString?  why not just use .size() on the wstring and
avoid the overhead?

[Avi (use Gerrit), 2009-10-14 21:32:41]

http://codereview.chromium.org/278004/diff/4001/9
File chrome/browser/cocoa/preferences_window_controller.mm (right):

http://codereview.chromium.org/278004/diff/4001/9#newcode768
Line 768: [self recordUserAction:L"Options_IsUsingDefaultTheme_Disable"];
Are these values backward? When they use the default theme, shouldn't that be
Options_IsUsingDefaultTheme_Enable?

http://codereview.chromium.org/278004/diff/4001/9#newcode775
Line 775: return [currTheme isKindOfClass:[NSString class]] && [currTheme
length] == 0;
On 2009/10/14 21:22:03, TVL wrote:
> why do these checks with NSString?  why not just use .size() on the wstring
and
> avoid the overhead?

Also, how is the isKindOfClass call useful? Do you doubt that
base::SysWideToNSString will return something other than an NSString?

[Miranda Callahan, 2009-10-14 21:44:36]

Fixed issues from Avi and TVL.

http://codereview.chromium.org/278004/diff/4001/9
File chrome/browser/cocoa/preferences_window_controller.mm (right):

http://codereview.chromium.org/278004/diff/4001/9#newcode768
Line 768: [self recordUserAction:L"Options_IsUsingDefaultTheme_Disable"];
On 2009/10/14 21:32:42, Avi wrote:
> Are these values backward? When they use the default theme, shouldn't that be
> Options_IsUsingDefaultTheme_Enable?

I guess you are right; we *enable* that option, which gets negated in the prefs
by the value transformer to *disable* the "reset to default theme" button. 
Fixed.

http://codereview.chromium.org/278004/diff/4001/9#newcode775
Line 775: return [currTheme isKindOfClass:[NSString class]] && [currTheme
length] == 0;
On 2009/10/14 21:22:03, TVL wrote:
> why do these checks with NSString?  why not just use .size() on the wstring
and
> avoid the overhead?

Good question; done.

http://codereview.chromium.org/278004/diff/4001/9#newcode775
Line 775: return [currTheme isKindOfClass:[NSString class]] && [currTheme
length] == 0;
On 2009/10/14 21:32:42, Avi wrote:
> On 2009/10/14 21:22:03, TVL wrote:
> > why do these checks with NSString?  why not just use .size() on the wstring
> and
> > avoid the overhead?
> 
> Also, how is the isKindOfClass call useful? Do you doubt that
> base::SysWideToNSString will return something other than an NSString?

These are unfortunate artifacts of my learning Cocoa and trying to do everything
in Objective C all at once.  Fixed both.

[Avi (use Gerrit), 2009-10-14 21:47:43]

LG